-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new build on save with watch mode #2096
Draft
Techatrix
wants to merge
28
commits into
master
Choose a base branch
from
techatrix/dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,429
−908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tried this with a few of my projects and it works well ⚡ |
Techatrix
force-pushed
the
techatrix/dev
branch
from
December 1, 2024 21:36
892dad3
to
461105b
Compare
Techatrix
force-pushed
the
techatrix/dev
branch
from
December 9, 2024 23:16
53d285f
to
02bc35d
Compare
…n has been received
This also fixes a minor bug where cImport diagnostics would only be reported after a document has been modified
The main motivation for this is to keep support for the latest mach nominated zig version which is `0.14.0-dev.1911+3bf89f55c`.
Techatrix
force-pushed
the
techatrix/dev
branch
from
December 11, 2024 18:43
8736816
to
bee1c90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the current build on save implementation with a new one that is based on Zig's
zig build --watch
feature. This can be combined with thebuild_on_save_args
config option to enable incremental compilation. fixes #2001Here is a small showcase where I use the equivalent of
zig build check --watch -fincremental
:output.webm
Show Video
I used the Error Lens extension to display the error messages inline.
The minimum runtime Zig version has been bumped from
0.12.0
to0.14.0-dev.310+9d38e82b5
. This means that the latest mach nominated zig version (0.14.0-dev.1911+3bf89f55c
) is still supported.The build on save diagnostics are no longer removed after editing the document. The source location of the error message is not being updated when the document gets modified but this can be implement in the future.
std.zig.ErrorBundle
which unblocks use reference trace to provide better build-on-save source locations for errors #2018I have only tested this on Linux and Windows with VS Code. Who know what kind of bugs are still lurking around 🤷