Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ScaNN index #1

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Support ScaNN index #1

merged 1 commit into from
Aug 10, 2023

Conversation

chasingegg
Copy link
Collaborator

@mergify
Copy link

mergify bot commented Aug 9, 2023

@chasingegg Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

src/index/ivf/ivf_config.h Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@e896528). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9680b8e differs from pull request most recent head 6ab1e41. Consider uploading reports for the commit 6ab1e41 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##             main   #1   +/-   ##
===================================
  Coverage        ?    0           
===================================
  Files           ?    0           
  Lines           ?    0           
  Branches        ?    0           
===================================
  Hits            ?    0           
  Misses          ?    0           
  Partials        ?    0           

Signed-off-by: chasingegg <chao.gao@zilliz.com>
@PwzXxm
Copy link
Collaborator

PwzXxm commented Aug 10, 2023

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, PwzXxm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chasingegg
Copy link
Collaborator Author

/kind improvement

@PwzXxm
Copy link
Collaborator

PwzXxm commented Aug 10, 2023

/lgtm

@liliu-z liliu-z merged commit 73f0335 into zilliztech:main Aug 10, 2023
7 checks passed
@chasingegg chasingegg deleted the scann-dev branch August 10, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants