Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ScalarQuantizer performance, ESPECIALLY on old GCC #209

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

alexanderguzhva
Copy link
Collaborator

@alexanderguzhva alexanderguzhva commented Nov 22, 2023

Introduces FAISS_ALWAYS_INLINE pragma directive and improves ScalarQuantizer performance with it.

Most of performance-critical methods for ScalarQuantizer are marked with this new directive, because a compiler (especially, an old one) may be unable to inline it properly. In some of my GCC experiments, such an inlining yields +50% queries per second in a search.

The corresponding Faiss PR is facebookresearch/faiss#3141.

/kind improvement

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Copy link

mergify bot commented Nov 22, 2023

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@mergify mergify bot added ci-passed and removed ci-passed labels Nov 22, 2023
@cydrain
Copy link
Collaborator

cydrain commented Nov 23, 2023

/lgtm

@zhengbuqian
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yellow-shine
Copy link
Collaborator

/run-e2e

@mergify mergify bot added the ci-passed label Nov 23, 2023
@cydrain
Copy link
Collaborator

cydrain commented Nov 23, 2023

/kind improvement

@sre-ci-robot sre-ci-robot merged commit 0561e2b into zilliztech:main Nov 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants