Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IVF_FLAT_NM #39

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Remove IVF_FLAT_NM #39

merged 1 commit into from
Sep 7, 2023

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Aug 30, 2023 •
edited
Loading

Issue: #30

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed label Aug 30, 2023
@mergify mergify bot added the ci-passed label Aug 31, 2023
@cydrain
Copy link
Collaborator Author

cydrain commented Aug 31, 2023

/hold

cqy123456
cqy123456 reviewed Aug 31, 2023
View reviewed changes
src/index/ivf/ivf.cc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #39 (e95da59) into main (986ab55) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head e95da59 differs from pull request most recent head 7a9ad84. Consider uploading reports for the commit 7a9ad84 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@    Coverage Diff     @@
##   main   #39   +/-   ##
==========================
==========================

@mergify mergify bot removed the ci-passed label Aug 31, 2023
@cqy123456
Copy link
Collaborator

/lgtm

@cydrain
Copy link
Collaborator Author

cydrain commented Aug 31, 2023

/unhold

@sre-ci-robot sre-ci-robot removed the lgtm label Sep 1, 2023
@cydrain cydrain force-pushed the caiyd_remove_ivf_flat_nm branch 3 times, most recently from f2e9765 to 69903a7 Compare September 1, 2023 14:36
@cydrain
Copy link
Collaborator Author

cydrain commented Sep 4, 2023

/hold

@cydrain cydrain force-pushed the caiyd_remove_ivf_flat_nm branch 3 times, most recently from c7bfc3e to 59eb18d Compare September 4, 2023 07:15
cqy123456
cqy123456 reviewed Sep 5, 2023
View reviewed changes
src/common/utils.cc Outdated Show resolved Hide resolved
@cydrain cydrain force-pushed the caiyd_remove_ivf_flat_nm branch 6 times, most recently from ab5bcfd to f457d18 Compare September 5, 2023 11:26
@cydrain
Copy link
Collaborator Author

cydrain commented Sep 5, 2023 •
edited
Loading

Milvus image:
harbor.milvus.io/milvus/milvus:cydrain-caiyd_remove_ivf_flat_nm-8177c05-20230906

Upgrade test:
https://qa-jenkins.milvus.io/blue/organizations/jenkins/deploy_test_cron/detail/deploy_test_cron/1312/pipeline/

@cydrain cydrain force-pushed the caiyd_remove_ivf_flat_nm branch 2 times, most recently from 5c242a3 to ed8dd0a Compare September 6, 2023 03:44
@mergify mergify bot added the ci-passed label Sep 6, 2023
@mergify mergify bot added ci-passed and removed ci-passed labels Sep 7, 2023
@cydrain
Copy link
Collaborator Author

cydrain commented Sep 7, 2023

/hold

@cqy123456
Copy link
Collaborator

/lgtm

@cydrain
Remove IVF_FLAT_NM
7a9ad84 
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Sep 7, 2023
@mergify mergify bot removed the ci-passed label Sep 7, 2023
@cqy123456
Copy link
Collaborator

/lgtm

@mergify mergify bot added the ci-passed label Sep 7, 2023
@cydrain
Copy link
Collaborator Author

cydrain commented Sep 7, 2023

/unhold

@sre-ci-robot sre-ci-robot merged commit dbd7756 into zilliztech:main Sep 7, 2023
7 checks passed
@cydrain cydrain deleted the caiyd_remove_ivf_flat_nm branch September 7, 2023 07:55
foxspy added a commit to foxspy/knowhere that referenced this pull request Oct 23, 2023
@foxspy
Merge pull request zilliztech#39 from zilliztech/sync_knowhere_branch
a0f5162 
Sync knowhere branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqy123456 cqy123456 cqy123456 left review comments

@liliu-z liliu-z Awaiting requested review from liliu-z

Assignees

@cqy123456 cqy123456

Labels
approved ci-passed dco-passed kind/enhancement lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cydrain @sre-ci-robot @cqy123456