Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix segment fault when use config load a list #49

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

Presburger
Copy link
Collaborator

issue: #46

if code run at this line, will cause segment fault, val got a empty std::optional<list>.

Signed-off-by: Yusheng.Ma <Yusheng.Ma@zilliz.com>
@mergify
Copy link

mergify bot commented Sep 4, 2023

@Presburger 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@liliu-z
Copy link
Collaborator

liliu-z commented Sep 4, 2023

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liliu-z
Copy link
Collaborator

liliu-z commented Sep 4, 2023

/kind improvement

@chasingegg
Copy link
Collaborator

/lgtm

@mergify mergify bot added the ci-passed label Sep 5, 2023
@sre-ci-robot sre-ci-robot merged commit e9cf4de into zilliztech:main Sep 5, 2023
7 checks passed
foxspy added a commit to foxspy/knowhere that referenced this pull request Dec 7, 2023
Signed-off-by: xianliang <xian_hust@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants