Support numpy array to sparse dataset in pyknowhere api #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chasingegg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
=========================================
+ Coverage 0 71.40% +71.40%
=========================================
Files 0 69 +69
Lines 0 4728 +4728
=========================================
+ Hits 0 3376 +3376
- Misses 0 1352 +1352 |
chasingegg
changed the title
zhengbuqian
reviewed
Jun 20, 2024
python/knowhere/knowhere.i
Outdated
| @@ -355,6 +359,39 @@ CurrentVersion() { | |||
| return knowhere::Version::GetCurrentVersion().VersionNumber(); | |||
| } | |||
|
|
|||
| knowhere::DataSetPtr | |||
| Array2SparseDataSet(float* data, int nb1, int* ids, int nb2, int64_t* indptr, int nrow) { | |||
There was a problem hiding this comment.
rename nrow since it doesn't mean nrow
python/knowhere/knowhere.i
Outdated
| int64_t start = indptr[i]; | ||
| int64_t end = indptr[i+1]; | ||
| if (start == end) { | ||
| continue; |
There was a problem hiding this comment.
actually we don't allow empty row. let's throw an error?
|
look good to me overall, with nits |
Signed-off-by: chasingegg <chao.gao@zilliz.com>
|
/lgtm |
xxxlzhxxx
pushed a commit
to xxxlzhxxx/knowhere
that referenced
this pull request
Jul 23, 2024
…#654) Signed-off-by: chasingegg <chao.gao@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind improvement