Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cagra support train on gpu, search on cpu, use hnswlib #661

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

Presburger
Copy link
Collaborator

Make the CAGRA index compatible with Knowhere's HNSWlib, supporting GPU training and CPU search scenarios.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Jun 21, 2024

@Presburger 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
@liliu-z
Copy link
Collaborator

liliu-z commented Jun 21, 2024

/lgtm

@Presburger
Copy link
Collaborator Author

/run e2e

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.40%. Comparing base (3c46f4c) to head (deac882).
Report is 96 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #661       +/-   ##
=========================================
+ Coverage      0   71.40%   +71.40%     
=========================================
  Files         0       69       +69     
  Lines         0     4728     +4728     
=========================================
+ Hits          0     3376     +3376     
- Misses        0     1352     +1352     

see 69 files with indirect coverage changes

@Presburger
Copy link
Collaborator Author

/retest

@mergify mergify bot added the ci-passed label Jun 24, 2024
@liliu-z
Copy link
Collaborator

liliu-z commented Jun 24, 2024

/kind improvement

Copy link

mergify bot commented Jun 24, 2024

@Presburger Please remove redundant kind/xxx labels and make sure that there is only one kind/xxx label of your Pull Request. (eg. “/remove-kind improvement”)

@sre-ci-robot sre-ci-robot merged commit 1a9d7ad into zilliztech:main Jun 24, 2024
13 checks passed
xxxlzhxxx pushed a commit to xxxlzhxxx/knowhere that referenced this pull request Jul 23, 2024
* cagra support train on gpu, search on cpu, use hnswlib

Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>

* cagra support train on gpu, search on cpu, use hnswlib

Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>

---------

Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants