-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all APIs' input parameter to 'const DataSetPtr' #667
Update all APIs' input parameter to 'const DataSetPtr' #667
Conversation
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cydrain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cydrain 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
=========================================
+ Coverage 0 71.51% +71.51%
=========================================
Files 0 69 +69
Lines 0 4718 +4718
=========================================
+ Hits 0 3374 +3374
- Misses 0 1344 +1344 |
/hold |
/lgtm please hold the submission, and get a PR ready in Cardinal that adapts this change before unholding. |
/unhold |
/kind improvement |
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
Issue: #666