Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all APIs' input parameter to 'const DataSetPtr' #667

Merged

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Jun 26, 2024

Issue: #666

Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented Jun 26, 2024

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.51%. Comparing base (3c46f4c) to head (3a21892).
Report is 98 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #667       +/-   ##
=========================================
+ Coverage      0   71.51%   +71.51%     
=========================================
  Files         0       69       +69     
  Lines         0     4718     +4718     
=========================================
+ Hits          0     3374     +3374     
- Misses        0     1344     +1344     

see 69 files with indirect coverage changes

@cydrain
Copy link
Collaborator Author

cydrain commented Jun 26, 2024

/hold

@zhengbuqian
Copy link
Collaborator

/lgtm

please hold the submission, and get a PR ready in Cardinal that adapts this change before unholding.

@cydrain
Copy link
Collaborator Author

cydrain commented Jun 26, 2024

/unhold

@cydrain
Copy link
Collaborator Author

cydrain commented Jun 26, 2024

/kind improvement

@sre-ci-robot sre-ci-robot merged commit ae6a8ef into zilliztech:main Jun 26, 2024
13 checks passed
@cydrain cydrain deleted the caiyd_change_api_shared_ptr_dataset branch June 26, 2024 10:10
xxxlzhxxx pushed a commit to xxxlzhxxx/knowhere that referenced this pull request Jul 23, 2024
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants