-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix openblas thread version ivf build performance degradation #741
Conversation
@Presburger 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
=========================================
+ Coverage 0 71.99% +71.99%
=========================================
Files 0 70 +70
Lines 0 5163 +5163
=========================================
+ Hits 0 3717 +3717
- Misses 0 1446 +1446 |
5216204
to
3d308b8
Compare
Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liliu-z, Presburger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug |
@@ -239,10 +241,18 @@ class ThreadPool { | |||
omp_before = build_pool_->size(); | |||
} | |||
|
|||
#if defined(OPENBLAS_OS_LINUX) | |||
blas_thread_before = openblas_get_num_threads(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we set the blas_thread_before same way as omp_before
issue: #739