Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix openblas thread version ivf build performance degradation #741

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

Presburger
Copy link
Collaborator

@Presburger Presburger commented Jul 30, 2024

issue: #739

include/knowhere/comp/thread_pool.h Outdated Show resolved Hide resolved
Copy link

mergify bot commented Jul 30, 2024

@Presburger 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.99%. Comparing base (3c46f4c) to head (5216204).
Report is 133 commits behind head on main.

Current head 5216204 differs from pull request most recent head 3d308b8

Please upload reports for the commit 3d308b8 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #741       +/-   ##
=========================================
+ Coverage      0   71.99%   +71.99%     
=========================================
  Files         0       70       +70     
  Lines         0     5163     +5163     
=========================================
+ Hits          0     3717     +3717     
- Misses        0     1446     +1446     

see 70 files with indirect coverage changes

Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liliu-z
Copy link
Collaborator

liliu-z commented Jul 30, 2024

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug This PR is a bug fix label Jul 30, 2024
@liliu-z liliu-z merged commit fc522d7 into zilliztech:main Jul 30, 2024
7 of 10 checks passed
@@ -239,10 +241,18 @@ class ThreadPool {
omp_before = build_pool_->size();
}

#if defined(OPENBLAS_OS_LINUX)
blas_thread_before = openblas_get_num_threads();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set the blas_thread_before same way as omp_before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants