Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let HNSW throw exception when calculate distance for unsupported DataType #808

Merged

Conversation

cydrain
Copy link
Collaborator

@cydrain cydrain commented Sep 2, 2024

No description provided.

…Type

Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
Copy link

mergify bot commented Sep 2, 2024

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@cydrain
Copy link
Collaborator Author

cydrain commented Sep 2, 2024

/kind improvement

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.66%. Comparing base (3c46f4c) to head (58b19c7).
Report is 167 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #808       +/-   ##
=========================================
+ Coverage      0   61.66%   +61.66%     
=========================================
  Files         0       84       +84     
  Lines         0     6149     +6149     
=========================================
+ Hits          0     3792     +3792     
- Misses        0     2357     +2357     

see 84 files with indirect coverage changes

Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Sep 3, 2024
@sre-ci-robot sre-ci-robot merged commit f1818e0 into zilliztech:main Sep 3, 2024
13 checks passed
@cydrain cydrain deleted the caiyd_opt_hnsw_multi_data_type_handle branch September 3, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants