Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple clang #828

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Apple clang #828

merged 1 commit into from
Sep 13, 2024

Conversation

Presburger
Copy link
Collaborator

No description provided.

Copy link

mergify bot commented Sep 10, 2024

⚠️ The sha of the head commit of this PR conflicts with #827. Mergify cannot evaluate rules on this PR. ⚠️

Copy link

mergify bot commented Sep 10, 2024

@Presburger 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.85%. Comparing base (3c46f4c) to head (25434f9).
Report is 186 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #828       +/-   ##
=========================================
+ Coverage      0   73.85%   +73.85%     
=========================================
  Files         0       84       +84     
  Lines         0     6100     +6100     
=========================================
+ Hits          0     4505     +4505     
- Misses        0     1595     +1595     

see 84 files with indirect coverage changes

@Presburger
Copy link
Collaborator Author

/kind improvement

@alexanderguzhva
Copy link
Collaborator

/lgtm

@alexanderguzhva
Copy link
Collaborator

/lgtm

Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
@mergify mergify bot added the ci-passed label Sep 13, 2024
Copy link
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, liliu-z, Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Presburger,foxspy,liliu-z]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e88cae6 into zilliztech:main Sep 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants