Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add knowhere static interface #836

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented Sep 12, 2024

issue: #795
this pr introduce some index static interface, which could be called when the index has not created (such as index config check, property prediction, or resource estimate)

Copy link

mergify bot commented Sep 12, 2024

@foxspy 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@foxspy
Copy link
Collaborator Author

foxspy commented Sep 12, 2024

/kind enhancement

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.86%. Comparing base (3c46f4c) to head (d9a7450).
Report is 197 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #836       +/-   ##
=========================================
+ Coverage      0   73.86%   +73.86%     
=========================================
  Files         0       86       +86     
  Lines         0     6188     +6188     
=========================================
+ Hits          0     4571     +4571     
- Misses        0     1617     +1617     

see 86 files with indirect coverage changes

src/index/ivf/ivf.cc Show resolved Hide resolved
include/knowhere/comp/knowhere_check.h Show resolved Hide resolved
include/knowhere/config.h Show resolved Hide resolved
include/knowhere/index/index_static.h Outdated Show resolved Hide resolved
include/knowhere/index/index_static.h Show resolved Hide resolved
include/knowhere/index/index_static.h Show resolved Hide resolved
src/index/ivf/ivf.cc Show resolved Hide resolved
include/knowhere/index/index_static.h Show resolved Hide resolved
@foxspy foxspy force-pushed the add_knowhere_static_interface branch 2 times, most recently from 537adda to 5fc4101 Compare September 14, 2024 15:17
@mergify mergify bot added the ci-passed label Sep 14, 2024
@foxspy foxspy force-pushed the add_knowhere_static_interface branch from 5fc4101 to 6b082c5 Compare September 14, 2024 16:11
@mergify mergify bot added ci-passed and removed ci-passed labels Sep 14, 2024
Copy link
Collaborator

@alexanderguzhva alexanderguzhva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. fix typos
  2. restore templates classes
  3. some code format changes

src/index/hnsw/faiss_hnsw.cc Outdated Show resolved Hide resolved
src/index/hnsw/faiss_hnsw.cc Outdated Show resolved Hide resolved
src/index/hnsw/faiss_hnsw.cc Outdated Show resolved Hide resolved
src/index/hnsw/faiss_hnsw.cc Outdated Show resolved Hide resolved
src/index/hnsw/faiss_hnsw.cc Outdated Show resolved Hide resolved
src/index/hnsw/faiss_hnsw.cc Show resolved Hide resolved
src/index/hnsw/faiss_hnsw.cc Outdated Show resolved Hide resolved
src/index/hnsw/faiss_hnsw.cc Outdated Show resolved Hide resolved
src/index/hnsw/faiss_hnsw.cc Show resolved Hide resolved
src/index/hnsw/faiss_hnsw.cc Show resolved Hide resolved
@alexanderguzhva
Copy link
Collaborator

/hold

@foxspy foxspy force-pushed the add_knowhere_static_interface branch from 6b082c5 to 6b0bc7a Compare September 18, 2024 05:28
@mergify mergify bot removed the ci-passed label Sep 18, 2024
@foxspy foxspy force-pushed the add_knowhere_static_interface branch 3 times, most recently from c292025 to e8b75ca Compare September 18, 2024 06:36
@mergify mergify bot added the ci-passed label Sep 18, 2024
@mergify mergify bot removed the ci-passed label Sep 18, 2024
tests/ut/test_index_check.cc Show resolved Hide resolved
src/index/index_static.cc Outdated Show resolved Hide resolved
src/index/index_static.cc Outdated Show resolved Hide resolved
Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@foxspy foxspy force-pushed the add_knowhere_static_interface branch from e8b75ca to d9a7450 Compare September 18, 2024 15:13
@alexanderguzhva
Copy link
Collaborator

/lgtm

@foxspy
Copy link
Collaborator Author

foxspy commented Sep 19, 2024

/unhold

@foxspy
Copy link
Collaborator Author

foxspy commented Sep 19, 2024

@alexanderguzhva pls help remove the change request~thanks

@mergify mergify bot removed the ci-passed label Sep 19, 2024
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Presburger
Copy link
Collaborator

/lgtm

@foxspy
Copy link
Collaborator Author

foxspy commented Sep 19, 2024

/run-e2e

@sre-ci-robot sre-ci-robot merged commit 61c1d09 into zilliztech:main Sep 19, 2024
13 checks passed
@mergify mergify bot removed the ci-passed label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants