Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cache for graph search #872

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

liliu-z
Copy link
Collaborator

@liliu-z liliu-z commented Sep 26, 2024

  1. Remove the cache for better explainability.
  2. Remove for_tuning param
  3. Some auto format changes

issue: #864

/kind enhancement

Copy link

mergify bot commented Sep 26, 2024

@liliu-z 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@liliu-z
Copy link
Collaborator Author

liliu-z commented Sep 26, 2024

/kind enhancement

Signed-off-by: Li Liu <li.liu@zilliz.com>
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.67%. Comparing base (3c46f4c) to head (b097b78).
Report is 210 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #872       +/-   ##
=========================================
+ Coverage      0   77.67%   +77.67%     
=========================================
  Files         0       84       +84     
  Lines         0     6364     +6364     
=========================================
+ Hits          0     4943     +4943     
- Misses        0     1421     +1421     

see 84 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 27, 2024
Copy link
Collaborator

@hhy3 hhy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hhy3, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 85feac2 into zilliztech:main Sep 27, 2024
14 checks passed
@liliu-z liliu-z deleted the remove_cache branch September 27, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants