Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group search #913

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

alexanderguzhva
Copy link
Collaborator

@alexanderguzhva alexanderguzhva commented Oct 28, 2024

Fixes milvus-io/milvus#37135
The problem was in the reinterpreting fp16 and bf16 data as fp32 one

this PR contains #904 as well

knowhere issue: #916

Copy link

mergify bot commented Oct 28, 2024

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.22%. Comparing base (3c46f4c) to head (064c323).
Report is 230 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #913       +/-   ##
=========================================
+ Coverage      0   79.22%   +79.22%     
=========================================
  Files         0       81       +81     
  Lines         0     6348     +6348     
=========================================
+ Hits          0     5029     +5029     
- Misses        0     1319     +1319     

see 81 files with indirect coverage changes

Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@alexanderguzhva
Copy link
Collaborator Author

/rerun-e2e

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liliu-z
Copy link
Collaborator

liliu-z commented Oct 30, 2024

/kind enhancement

@liliu-z liliu-z merged commit ecc27ac into zilliztech:main Oct 30, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants