fix : add config check for open and closed range settings #915
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@foxspy 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
include/knowhere/config.h
Outdated
| @@ -115,6 +115,7 @@ struct Entry<CFG_FLOAT> { | |||
| std::optional<CFG_FLOAT::value_type> default_val; | |||
| uint32_t type; | |||
| std::optional<std::pair<CFG_FLOAT::value_type, CFG_FLOAT::value_type>> range; | |||
| std::optional<std::pair<bool, bool>> range_included; | |||
There was a problem hiding this comment.
please consider packing range into a structure Range, which would contain all the logic, including something like bool Range::within(float value) {} and std::string Range::to_string() {} (which produces a string representation)
There was a problem hiding this comment.
Good idea~ I will apply it
foxspy
force-pushed
the
add_range_check_master
branch
2 times, most recently
from
d33e629
to
a088b60
Compare
|
/lgtm |
Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
foxspy
force-pushed
the
add_range_check_master
branch
from
a088b60
to
5bf4dae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
=========================================
+ Coverage 0 79.25% +79.25%
=========================================
Files 0 81 +81
Lines 0 6350 +6350
=========================================
+ Hits 0 5033 +5033
- Misses 0 1317 +1317 |
|
/lgtm |
|
/kind improvement |
issue: milvus-io/milvus#37269