Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: BF supports ids of base_data starting from a specific value #941

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

cqy123456
Copy link
Collaborator

@cqy123456 cqy123456 commented Nov 13, 2024

issue: #942

Copy link

mergify bot commented Nov 13, 2024

@cqy123456 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.24%. Comparing base (3c46f4c) to head (d6f77e9).
Report is 247 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #941       +/-   ##
=========================================
+ Coverage      0   74.24%   +74.24%     
=========================================
  Files         0       82       +82     
  Lines         0     6628     +6628     
=========================================
+ Hits          0     4921     +4921     
- Misses        0     1707     +1707     

see 82 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 13, 2024
@alexanderguzhva
Copy link
Collaborator

@cqy123456 lgtm, what is the practical use case for this optimization? Basically, I wonder why this change was implemented for the brute-force search only

@cqy123456
Copy link
Collaborator Author

cqy123456 commented Nov 14, 2024

Raw data within a field is discontinuous in milvus. If the rows number in a raw data block is not aligned with 8, we need to copy a part of the bitset to knowhere. We also need to transfer Knowhere's default ID to an external ID. This PR is to enable Knowhere to obtain external IDs, reduce the copying of bitsets, and implement ID conversion.

Copy link
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@foxspy
Copy link
Collaborator

foxspy commented Nov 14, 2024

/kind improvement

@sre-ci-robot sre-ci-robot merged commit 69318d8 into zilliztech:main Nov 14, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants