-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: BF supports ids of base_data starting from a specific value #941
Conversation
@cqy123456 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
beff789
to
d6f77e9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
=========================================
+ Coverage 0 74.24% +74.24%
=========================================
Files 0 82 +82
Lines 0 6628 +6628
=========================================
+ Hits 0 4921 +4921
- Misses 0 1707 +1707 |
@cqy123456 lgtm, what is the practical use case for this optimization? Basically, I wonder why this change was implemented for the brute-force search only |
Raw data within a field is discontinuous in milvus. If the rows number in a raw data block is not aligned with 8, we need to copy a part of the bitset to knowhere. We also need to transfer Knowhere's default ID to an external ID. This PR is to enable Knowhere to obtain external IDs, reduce the copying of bitsets, and implement ID conversion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cqy123456, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind improvement |
issue: #942