Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_should_read func function exclude logic error #151

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Nov 5, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.74%. Comparing base (e64af8b) to head (e1f0f97).

Files with missing lines Patch % Lines
server/cdc_impl.go 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   58.57%   58.74%   +0.16%     
==========================================
  Files          64       64              
  Lines        8316     8316              
==========================================
+ Hits         4871     4885      +14     
+ Misses       3127     3115      -12     
+ Partials      318      316       -2     
Files with missing lines Coverage Δ
server/cdc_impl.go 61.92% <80.00%> (+1.24%) ⬆️

@SimFG SimFG changed the title Fix get_should_read func function exclude logic error fix get_should_read func function exclude logic error Nov 5, 2024
Signed-off-by: SimFG <bang.fu@zilliz.com>
@SimFG SimFG merged commit 66886dd into zilliztech:main Nov 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants