Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide easy default layer for TestServer #3094

Closed
987Nabil opened this issue Sep 5, 2024 · 4 comments · Fixed by #3161
Closed

Provide easy default layer for TestServer #3094

987Nabil opened this issue Sep 5, 2024 · 4 comments · Fixed by #3161
Labels

Comments

@987Nabil
Copy link
Contributor

987Nabil commented Sep 5, 2024

Currently the docs give this example list of layers to provide

}.provideSome[Client with Driver](TestServer.layer)
  }.provide(
    ZLayer.succeed(Server.Config.default.onAnyOpenPort),
    Client.default,
    NettyDriver.customized,
    ZLayer.succeed(NettyConfig.defaultWithFastShutdown),
  )

This is unnecessary complex. To just run a simple test, we should have something like TestServer.simple of type ZLayer[Any, Nothing, TestServer & Server], that gives a good default for most tests.

@987Nabil 987Nabil added the enhancement New feature or request label Sep 5, 2024
@jdegoes
Copy link
Member

jdegoes commented Sep 18, 2024

/bounty $50 for fix, test case, and documentation.

Copy link

algora-pbc bot commented Sep 18, 2024

💎 $50 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #3094 with your implementation plan
  2. Submit work: Create a pull request including /claim #3094 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-http!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @987Nabil #3161

Copy link

algora-pbc bot commented Sep 23, 2024

💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward.

987Nabil added a commit to 987Nabil/zio-http that referenced this issue Sep 24, 2024
987Nabil added a commit to 987Nabil/zio-http that referenced this issue Sep 24, 2024
Copy link

algora-pbc bot commented Oct 16, 2024

🎉🎈 @987Nabil has been awarded $50! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants