Add a test of a middleware providing a context to a Routes
#2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
commented
Oct 18, 2023
zio-http/src/test/scala/zio/http/internal/middlewares/AuthSpec.scala
Outdated
Show resolved
Hide resolved
…ith_routes Add a test of a middleware providing a context to a `Routes`
guizmaii
requested review from
amitksingh1490,
jdegoes,
vigoo and
adamgfraser
as code owners
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2487 +/- ##
==========================================
+ Coverage 64.90% 64.94% +0.04%
==========================================
Files 136 136
Lines 7197 7197
Branches 1296 1296
==========================================
+ Hits 4671 4674 +3
+ Misses 2526 2523 -3 ☔ View full report in Codecov by Sentry. |
jdegoes
approved these changes
Oct 18, 2023
987Nabil
pushed a commit
to 987Nabil/zio-http
that referenced
this pull request
Oct 24, 2023
jdegoes
pushed a commit
that referenced
this pull request
Nov 29, 2023
…2470) * Improve OpenAPI model; Add OpenAPI generator for EndpointAPI (#1498) * Minimize schema for optional fields * Integrate main changes * Fix Scala 3 build * Fix exhaustive matching * More OpenAPI generation tests * Use latest zio-schema snapshot for Scala 3 macro derivation fix * Formatting * OpenAPI tests now compare json ASTs, to avoid string render differences * Refactoring * improve docs (#2482) * Add a test of a middleware providing a context to a `Routes` (#2487) * Add a test of a middleware providing a context to a `Routes` * Add a test of a middleware providing a context to a `Routes` * scalafmt * scalafmt * Remove usage of deprecated method in build.sbt (#2486) * Update sbt-github-actions to 0.18.0 (#2484) * Update sbt-github-actions to 0.18.0 * Regenerate GitHub Actions workflow Executed command: sbt githubWorkflowGenerate * Update netty-codec-http, ... to 4.1.100.Final (#2485) * Generate readme * OpenAPI gen support for all kinds of enums with(out) discriminators OpenAPI gen support for default values, optional and transient fields --------- Co-authored-by: TomTriple <mail@tomhoefer.de> Co-authored-by: Jules Ivanic <jules.ivanic@gmail.com> Co-authored-by: Scala Steward <43047562+scala-steward@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It gives an example on how to use a "providing middleware" when using
RoutesI struggled to find how