Need to change EntityQuery.insert(CaseClass) to EntityQuery.insertValue(CaseClass) for upstream Scala 3 issues. #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusaquilus
changed the title
deusaquilus
changed the title
deusaquilus
changed the title
deusaquilus
force-pushed
the
insert-value
branch
from
bcca427
to
b903d02
Compare
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 24, 2022
Cherry-pick changes from zio/zio-protoquill@5ed25aa also present in zio/zio-quill#2379.
odersky
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 24, 2022
Cherry-pick changes from zio/zio-protoquill@5ed25aa also present in zio/zio-quill#2379.
This was referenced Jan 28, 2022
olsdavis
pushed a commit
to olsdavis/dotty
that referenced
this pull request
Apr 4, 2022
Cherry-pick changes from zio/zio-protoquill@5ed25aa also present in zio/zio-quill#2379.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing EntityQuery.insert to EntityQuery.insertValue due to scala/scala3#14043. Technically the issue only affects protoquill but I want the APIs to be aligned as much as possible.