-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MS SQL #731
Support for MS SQL #731
Conversation
Nice! But should not we keep all jdbc related stuff in |
@getquill/maintainers We should definitely split jdbc module to different artifacts, as with async modules. Ideally, move quill-jdbc drivers/implementations to different repository |
So, do we have a consensus? Can we go with a different project? |
@juliano Sorry for the late feeback. I'd prefer to keep all jdbc integration under |
@fwbrasil sounds good to me. I'll change the test containers and put everything under |
@juliano any updates on the changes? |
@fwbrasil not yet because I am on holidays, I will be back in 10 days :) |
@juliano enjoy! :) |
build/Dockerfile-setup-sqlserver
Outdated
@@ -0,0 +1,11 @@ | |||
FROM phusion/baseimage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use debian:jessie image because all other containers are using it or better move mssql setup to setup container. Unfortunately official mssql container is available only as Ubuntu and RHEL based so this will be the only exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update that! 👍
@juliano We are solved issue with long running build by parallelizing Scala 2.11 and 2.12 builds. Also there are other possibilities to parallelize build, e.g. to build each module in separate job. |
WOW! @juliano you are my hero |
@kentongray I am glad to help! :) @mxl it's almost there, but it seems I need some help :/ |
@juliano I'm here or ping me in Gitter. |
4b73e79
to
3eca2cd
Compare
ae4c835
to
3a2833d
Compare
@mxl it seems it didn't worked :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliano For some reason it fails when connecting to MS SQL Server because database was damaged(?):
Sql Server ready
Msg 922, Level 14, State 1, Server 8eedbd6c1d56, Line 1
Database 'model' is being recovered. Waiting until recovery is finished.
Sqlcmd: Error: Microsoft ODBC Driver 13 for SQL Server : Cannot open database "quill_test" requested by the login. The login failed..
Sqlcmd: Error: Microsoft ODBC Driver 13 for SQL Server : Login failed for user 'sa'..
build/Dockerfile-setup
Outdated
|
||
RUN dpkg-reconfigure -f noninteractive tzdata && \ | ||
sed -i -e 's/# en_US.UTF-8 UTF-8/en_US.UTF-8 UTF-8/' /etc/locale.gen && \ | ||
sed -i -e 's/# nb_NO.UTF-8 UTF-8/nb_NO.UTF-8 UTF-8/' /etc/locale.gen && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need in nb_NO.UTF-8 locale and tzdata reconfiguration (see http://stackoverflow.com/a/38553499/746347)
build/Dockerfile-setup
Outdated
sed -i -e 's/# nb_NO.UTF-8 UTF-8/nb_NO.UTF-8 UTF-8/' /etc/locale.gen && \ | ||
echo 'LANG="nb_NO.UTF-8"'>/etc/default/locale && \ | ||
dpkg-reconfigure --frontend=noninteractive locales && \ | ||
update-locale LANG=nb_NO.UTF-8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
en_US.UTF-8 should be here.
awesome! not to pester and I'll patiently wait but I'm eager to try this out, will this be auto published as a snapshot or will I need to wait till the next release? |
@kentongray each successful build in master is published as a snapshot to sonatype :) |
Just letting you know I tested the ms sql support and initial tests were super promising! Love this lib! Thanks everyone |
Fixes #451
Problem
Quill doesn't support MS SQL Server. This PR adds this support.
Solution
Implemented Sql Server context and dialect
Notes
As suggested by @gustavoamigo I put this code in a different project in order to not mess up with the current build or make it slower, once that I need a different docker image to do the setup. To set up the entire environment just run:
docker-compose stop && docker-compose rm && docker-compose run --rm setup && docker-compose run --rm setup-sqlserver
I am not entirely sure if this is the way to go, any suggestion here would be great.
Checklist
README.md
if applicable[WIP]
to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormat
to make sure that the source files are formatted@getquill/maintainers