Fix TypeError when substr return FALSE

[XOlegator]

There is type error on PHP 7.2.32:

Fatal error: Uncaught TypeError: trim() expects parameter 1 to be string, boolean given in /home/webmaster/data/www/vendor/zircote/swagger-php/src/Context.php:212 Stack trace: #0 /home/webmaster/data/www/vendor/zircote/swagger-php/src/Context.php(212): trim(false) #1 /home/webmaster/data/www/vendor/zircote/swagger-php/src/Processors/AugmentOperations.php(26): OpenApi\Context->phpdocDescription() #2 /home/webmaster/data/www/vendor/zircote/swagger-php/src/Analysis.php(466): OpenApi\Processors\AugmentOperations->__invoke(Object(OpenApi\Analysis)) #3 /home/webmaster/data/www/vendor/zircote/swagger-php/src/functions.php(57): OpenApi\Analysis->process(Array) #4 /home/webmaster/data/www/stolplit.ru/mobile_api/generate_doc.php(27): OpenApi\scan('/home/webmaster...') #5 {main} thrown in /home/webmaster/data/www/vendor/zircote/swagger-php/src/Context.php on line 212

This little patch fixes this issue

[DerManoMann]

Thanks for the PR.

Before merging, could you perhaps provide a simple example of how this can happen?

Also, is this only an issue with PHP 7.2.32 or is that just the version you happened to be using?

[XOlegator]

I looked under the debugger, in what place and with what values the script crashes in this place.
PHP 7.2 with mbstring.func_overload=2

$summary = 'Получение токена авторизации и данных пользователя';
$sameString = 'Получение токена авторизации и данных пользователя';
$res1 = substr($sameString, strlen($summary));
var_dump($res1); // <--- bool(false)

PHP 7.4 with mbstring.func_overload=2

$summary = 'Получение токена авторизации и данных пользователя';
$sameString = 'Получение токена авторизации и данных пользователя';
$res1 = substr($sameString, strlen($summary));
var_dump($res1); // <--- string(0) ""

So, return value of function substr() was changed in PHP ¯_(ツ)_/¯

[DerManoMann]

Thanks @XOlegator