-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to old repo #373
Conversation
There's also the link to zk-vscode extension on the marketplace.
But I guess we will update this once we update on the store. There's also the links in the go.sum file (line 141, 142). These get handle automatically by Go though, right?
|
@@ -15,8 +15,8 @@ | |||
* [Advanced search and filtering capabilities](docs/note-filtering.md) including [tags](docs/tags.md), links and mentions | |||
* [Integration with your favorite editors](docs/editors-integration.md): | |||
* [Any LSP-compatible editor](docs/editors-integration.md) | |||
* [`zk-nvim`](https://github.com/mickael-menu/zk-nvim) for Neovim 0.5+ | |||
* [`zk-vscode`](https://github.com/mickael-menu/zk-vscode) for Visual Studio Code | |||
* [`zk-nvim`](https://github.com/zk-org/zk.nvim) for Neovim 0.5+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we rename the link title to zk.nvim
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also in editors-integration.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we'll need to then change the actual url of the repo after this is changed.
This change will also break peoples plugin manager conf though. Not a huge issue, as it's easy to remedy on their end, but still. Just wanted to voice it, also as I'm not 100% clear on the benefits of the url change, so I can't appropriately measure the tradeoff.
All good for you to make a call on this @mcDevnagh .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you still need to rename from zk-nvim
to zk.nvim
now that the repos were transfered. For a fork it would be an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in agreement with Mickael.
The break in plugin managers occurs because most of them save them in directories of the name of the repository, in this case zk-nvim
, and they don't all delete repositories once downloaded. For lazy.nvim, you specifically need to call Lazy clean
or run clean via the UI. So if a user switches the URL without first cleaning, bad things can happen. However, because the repositories were transferred over, any network requests to https://github.com/mickael-menu/zk redirect to this repo, so end users can just leave in the https://github.com/mickael-menu/zk-nvim
URL or slug (i.e. mickael-menu/zk-nvim
).
New users of the zk-nvim plugin should use the new URL, and existing users can continue using the old.
I'm not even sure that new URLs would break plugin managers; I just know that none-ls.nvim thought so. However null-ls.nvim is archived, not transferred over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second staying with zk-nvim
for the repository name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should stick with zk-nvim
, in part to avoid confusion with the existing zk.nvim
plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hadn't even realized that the name was "taken." If we needed to change it, zk.nvim
should be off the table--we'll have to come up with something else--but it looks like we can stick with zk-nvim
and we'll never have to switch
build is failing because of a checksum mismatch in the |
zk-org/pretty#1 Once those occur, we can rerun the failed build |
Just beat me to it. All power went out in my building and internet down for 3-4 hours. Happened immediately as I hit Thanks for also doing that one! I've never cut a release before though... I guess it's these steps:
|
- fix handlebars test
I can publish the new version later today. Basically go does some magic with git tags. The contents of the release don't matter, since go just downloads the source code via git, much like you would clone the repo |
ah great. thanks for the links (both links are the same though?). edit: just seen there are some new prs to do before hand (won't be publishing then of course until they're done and you've given an ok to publish, or done yourself, fear not!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zk-org/pretty release cut, which allowed the workflow to pass. So all looks groovy.
LOL. I definitely meant to send 2 different links, but alas, I cannot remember. Serves me right for taking a week to respond. Thanks for taking care of this. |
No description provided.