Reduce number of runtime allocations #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllFi
requested review from
akolotov,
EvgenKor,
k1rill-fedoseev,
lok52 and
r0wdy1
lok52
reviewed
Dec 19, 2022
lok52
reviewed
Dec 19, 2022
lok52
approved these changes
Dec 20, 2022
EvgenKor
approved these changes
Dec 21, 2022
EvgenKor
added a commit
that referenced
this pull request
Feb 15, 2023
…ts) (#12) * use the multicore version of fawkes-crypto * Reduce number of runtime allocations (#5) * Replace try_to_vec with serialize * Try to decrypt not in place * Implement decrypt account, note and ss in place * Deserialize only necessary note hashes * Fix Cargo.toml * Refactor symcipher_decode * Bump version Co-authored-by: Evgen <evgen2k7@yandex.ru> * Set fawkes-crypto version: 4.3.4 (#6) * Uses https instead of ssh for fawkes-crypto (#7) * Feature/delegated deposits v2 (#11) * Add snark for verifying delegated deposits * delegated deposits fix & tests covered * change number of delegated deposits to 16 * add 0xffffffff prefix for message * join all snarks into one for delegated deposits * remove tree update from delegated deposit snark * Fix dependencies * remove out_commitment from dd secret inputs --------- Co-authored-by: Igor Gulamov <igor.gulamov@gmail.com> Co-authored-by: Vladimir Popov <rowdyme0@gmail.com> Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com> * Renaming package (libzeropool-zkbob) * Updating gitignore * Changing fawkes-crypto branch --------- Co-authored-by: vms <michail.vms@gmail.com> Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com> Co-authored-by: Igor Gulamov <igor.gulamov@gmail.com> Co-authored-by: Vladimir Popov <rowdyme0@gmail.com>
EvgenKor
added a commit
that referenced
this pull request
May 11, 2023
* use the multicore version of fawkes-crypto * Reduce number of runtime allocations (#5) * Replace try_to_vec with serialize * Try to decrypt not in place * Implement decrypt account, note and ss in place * Deserialize only necessary note hashes * Fix Cargo.toml * Refactor symcipher_decode * Bump version Co-authored-by: Evgen <evgen2k7@yandex.ru> * Set fawkes-crypto version: 4.3.4 (#6) * Uses https instead of ssh for fawkes-crypto (#7) * Improve cipher native lib: add methods to retrieve decryption keys, unit tests * Comment format * Exposing routine for nullifier intermediate hash computing * Refactoring tasks * Exposing routines to decrypt note and keys without validation * Increasing version (1.2.0) --------- Co-authored-by: vms <michail.vms@gmail.com> Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to reduce the number of runtime memory allocations during state syncing. The following was done:
There are still a lot of allocations in try_from_slice and rayon but it isn't something that could be easily fixed. There is some PR: near/borsh-rs#115 that tries to implement heapless deserialization but it's not ready yet.