Removed unneeded types for multi-txs #441
Annotations
30 warnings
deref on an immutable reference:
libzkbob-rs-node/src/helpers.rs#L92
warning: deref on an immutable reference
--> libzkbob-rs-node/src/helpers.rs:92:48
|
92 | match EdwardsPoint::subgroup_decompress(p, &*POOL_PARAMS.jubjub()) {
| ^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `POOL_PARAMS.jubjub()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `#[warn(clippy::borrow_deref_ref)]` on by default
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
libzkbob-rs/src/utils.rs#L17
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> libzkbob-rs/src/utils.rs:17:14
|
17 | .zip(hasher.finalize().into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `hasher.finalize()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do:
libzkbob-rs/src/merkle.rs#L1289
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
--> libzkbob-rs/src/merkle.rs:1289:44
|
1289 | fn fill_default_hashes(default_hashes: &mut Vec<Hash<P::Fr>>, params: &P) {
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [Hash<P::Fr>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
useless conversion to the same type: `std::ops::Range<usize>`:
libzkbob-rs/src/merkle.rs#L471
warning: useless conversion to the same type: `std::ops::Range<usize>`
--> libzkbob-rs/src/merkle.rs:471:21
|
471 | let array = (0..constants::HEIGHT)
| _____________________^
472 | | .into_iter()
| |________________________^ help: consider removing `.into_iter()`: `(0..constants::HEIGHT)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
manual implementation of `Option::map`:
libzkbob-rs/src/client/state.rs#L196
warning: manual implementation of `Option::map`
--> libzkbob-rs/src/client/state.rs:196:9
|
196 | / match prev_acc_indexes {
197 | | Some(idx) => Some((idx, self.get_account(idx).unwrap())),
198 | | _ => None,
199 | | }
| |_________^ help: try: `prev_acc_indexes.map(|idx| (idx, self.get_account(idx).unwrap()))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
|
type parameter `P` goes unused in function definition:
libzkbob-rs/src/address.rs#L170
warning: type parameter `P` goes unused in function definition
--> libzkbob-rs/src/address.rs:170:23
|
170 | fn pool_id_to_bytes_be<P: PoolParams>(pool_id: u32) -> [u8; POOL_ID_BYTES] {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
= note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
|
deref which would be done by auto-deref:
libs/kvdb-web/src/lib.rs#L107
warning: deref which would be done by auto-deref
--> libs/kvdb-web/src/lib.rs:107:46
|
107 | let _ = indexed_db::idb_commit_transaction(&*self.indexed_db, &transaction, self.columns);
| ^^^^^^^^^^^^^^^^^ help: try: `&self.indexed_db`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
non-binding `let` on a future:
libs/kvdb-web/src/lib.rs#L107
warning: non-binding `let` on a future
--> libs/kvdb-web/src/lib.rs:107:3
|
107 | let _ = indexed_db::idb_commit_transaction(&*self.indexed_db, &transaction, self.columns);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
= note: `#[warn(clippy::let_underscore_future)]` on by default
|
deref which would be done by auto-deref:
libs/kvdb-web/src/lib.rs#L70
warning: deref which would be done by auto-deref
--> libs/kvdb-web/src/lib.rs:70:44
|
70 | let mut stream = indexed_db::idb_cursor(&*inner, column);
| ^^^^^^^ help: try: `&inner`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
using tabs in doc comments is not recommended:
libs/kvdb-web/src/error.rs#L16
warning: using tabs in doc comments is not recommended
--> libs/kvdb-web/src/error.rs:16:59
|
16 | /// Accessing a Window or Worker Global Scope has failed.
| ^^^^ help: consider using four spaces per tab
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments
= note: `#[warn(clippy::tabs_in_doc_comments)]` on by default
|
deref on an immutable reference:
libzkbob-rs-node/src/helpers.rs#L92
warning: deref on an immutable reference
--> libzkbob-rs-node/src/helpers.rs:92:48
|
92 | match EdwardsPoint::subgroup_decompress(p, &*POOL_PARAMS.jubjub()) {
| ^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `POOL_PARAMS.jubjub()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `#[warn(clippy::borrow_deref_ref)]` on by default
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
libzkbob-rs/src/utils.rs#L17
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> libzkbob-rs/src/utils.rs:17:14
|
17 | .zip(hasher.finalize().into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `hasher.finalize()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do:
libzkbob-rs/src/merkle.rs#L1289
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
--> libzkbob-rs/src/merkle.rs:1289:44
|
1289 | fn fill_default_hashes(default_hashes: &mut Vec<Hash<P::Fr>>, params: &P) {
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [Hash<P::Fr>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
useless conversion to the same type: `std::ops::Range<usize>`:
libzkbob-rs/src/merkle.rs#L471
warning: useless conversion to the same type: `std::ops::Range<usize>`
--> libzkbob-rs/src/merkle.rs:471:21
|
471 | let array = (0..constants::HEIGHT)
| _____________________^
472 | | .into_iter()
| |________________________^ help: consider removing `.into_iter()`: `(0..constants::HEIGHT)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
manual implementation of `Option::map`:
libzkbob-rs/src/client/state.rs#L196
warning: manual implementation of `Option::map`
--> libzkbob-rs/src/client/state.rs:196:9
|
196 | / match prev_acc_indexes {
197 | | Some(idx) => Some((idx, self.get_account(idx).unwrap())),
198 | | _ => None,
199 | | }
| |_________^ help: try: `prev_acc_indexes.map(|idx| (idx, self.get_account(idx).unwrap()))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
|
deref which would be done by auto-deref:
libs/kvdb-web/src/lib.rs#L107
warning: deref which would be done by auto-deref
--> libs/kvdb-web/src/lib.rs:107:46
|
107 | let _ = indexed_db::idb_commit_transaction(&*self.indexed_db, &transaction, self.columns);
| ^^^^^^^^^^^^^^^^^ help: try: `&self.indexed_db`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
non-binding `let` on a future:
libs/kvdb-web/src/lib.rs#L107
warning: non-binding `let` on a future
--> libs/kvdb-web/src/lib.rs:107:3
|
107 | let _ = indexed_db::idb_commit_transaction(&*self.indexed_db, &transaction, self.columns);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
= note: `#[warn(clippy::let_underscore_future)]` on by default
|
deref which would be done by auto-deref:
libs/kvdb-web/src/lib.rs#L70
warning: deref which would be done by auto-deref
--> libs/kvdb-web/src/lib.rs:70:44
|
70 | let mut stream = indexed_db::idb_cursor(&*inner, column);
| ^^^^^^^ help: try: `&inner`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
type parameter `P` goes unused in function definition:
libzkbob-rs/src/address.rs#L170
warning: type parameter `P` goes unused in function definition
--> libzkbob-rs/src/address.rs:170:23
|
170 | fn pool_id_to_bytes_be<P: PoolParams>(pool_id: u32) -> [u8; POOL_ID_BYTES] {
| ^^^^^^^^^^^^^^^ help: consider removing the parameter
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
= note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
|
using tabs in doc comments is not recommended:
libs/kvdb-web/src/error.rs#L16
warning: using tabs in doc comments is not recommended
--> libs/kvdb-web/src/error.rs:16:59
|
16 | /// Accessing a Window or Worker Global Scope has failed.
| ^^^^ help: consider using four spaces per tab
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments
= note: `#[warn(clippy::tabs_in_doc_comments)]` on by default
|
check_and_test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, webfactory/ssh-agent@v0.5.4, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
check_and_test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, webfactory/ssh-agent@v0.5.4, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check_and_test
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check_and_test
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check_and_test
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
check_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|