Optimize shared secrets encryption scheme #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllFi
force-pushed
the
feature/encryption-optimization
branch
from
46d0cdd to
f581fb3
Compare
AllFi
force-pushed
the
feature/encryption-optimization
branch
from
f581fb3 to
3c21aa6
Compare
AllFi
changed the title
AllFi
requested review from
EvgenKor,
akolotov,
lok52,
k1rill-fedoseev and
r0wdy1
r0wdy1
reviewed
Oct 5, 2023
r0wdy1
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an implementation of the zkBob/libzeropool-zkbob#14.
In this PR the following was done:
kappahas been added to theKeysstruct.kappahas been added to all the calls ofencrypt,decrypt_out, andsymcipher_decryption_keys.parse_prefixhas been modified to accommodate the newVersionstruct.Related PR: zkBob/libzeropool-zkbob#15
Related draft in the docs: https://app.gitbook.com/o/-Loxl4rmid_XZStTXG0U/s/-MjSwkv4zokqCUebt-98/~/changes/512/implementation/zkbob-keys/~/details
Note: Please notify me before merging this PR so I can remove the temporary patch section in Cargo.toml and update versions.