Skip to content

Fixed tests

Fixed tests #429

GitHub Actions / clippy succeeded Feb 6, 2024 in 0s

clippy

9 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 9
Note 0
Help 0

Versions

  • rustc 1.75.0 (82e1608df 2023-12-21)
  • cargo 1.75.0 (1d8b05cdd 2023-11-20)
  • clippy 0.1.75 (82e1608 2023-12-21)

Annotations

Check warning on line 92 in libzkbob-rs-node/src/helpers.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref on an immutable reference

warning: deref on an immutable reference
  --> libzkbob-rs-node/src/helpers.rs:92:48
   |
92 |     match EdwardsPoint::subgroup_decompress(p, &*POOL_PARAMS.jubjub()) {
   |                                                ^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `POOL_PARAMS.jubjub()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
   = note: `#[warn(clippy::borrow_deref_ref)]` on by default

Check warning on line 17 in libzkbob-rs/src/utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
  --> libzkbob-rs/src/utils.rs:17:14
   |
17 |         .zip(hasher.finalize().into_iter())
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `hasher.finalize()`
   |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
  --> /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/iter/traits/iterator.rs:643:12
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 472 in libzkbob-rs/src/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::ops::Range<usize>`

warning: useless conversion to the same type: `std::ops::Range<usize>`
   --> libzkbob-rs/src/merkle.rs:471:21
    |
471 |           let array = (0..constants::HEIGHT)
    |  _____________________^
472 | |             .into_iter()
    | |________________________^ help: consider removing `.into_iter()`: `(0..constants::HEIGHT)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 199 in libzkbob-rs/src/client/state.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of `Option::map`

warning: manual implementation of `Option::map`
   --> libzkbob-rs/src/client/state.rs:196:9
    |
196 | /         match prev_acc_indexes {
197 | |             Some(idx) => Some((idx, self.get_account(idx).unwrap())),
198 | |             _ => None,
199 | |         }
    | |_________^ help: try: `prev_acc_indexes.map(|idx| (idx, self.get_account(idx).unwrap()))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
    = note: `#[warn(clippy::manual_map)]` on by default

Check warning on line 170 in libzkbob-rs/src/address.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type parameter `P` goes unused in function definition

warning: type parameter `P` goes unused in function definition
   --> libzkbob-rs/src/address.rs:170:23
    |
170 | fn pool_id_to_bytes_be<P: PoolParams>(pool_id: u32) -> [u8; POOL_ID_BYTES] {
    |                       ^^^^^^^^^^^^^^^ help: consider removing the parameter
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
    = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default

Check warning on line 107 in libs/kvdb-web/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
   --> libs/kvdb-web/src/lib.rs:107:46
    |
107 |         let _ = indexed_db::idb_commit_transaction(&*self.indexed_db, &transaction, self.columns);
    |                                                    ^^^^^^^^^^^^^^^^^ help: try: `&self.indexed_db`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 107 in libs/kvdb-web/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> libs/kvdb-web/src/lib.rs:107:3
    |
107 |         let _ = indexed_db::idb_commit_transaction(&*self.indexed_db, &transaction, self.columns);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
    = note: `#[warn(clippy::let_underscore_future)]` on by default

Check warning on line 70 in libs/kvdb-web/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
  --> libs/kvdb-web/src/lib.rs:70:44
   |
70 |             let mut stream = indexed_db::idb_cursor(&*inner, column);
   |                                                     ^^^^^^^ help: try: `&inner`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
   = note: `#[warn(clippy::explicit_auto_deref)]` on by default

Check warning on line 16 in libs/kvdb-web/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
  --> libs/kvdb-web/src/error.rs:16:59
   |
16 |     /// Accessing a Window or Worker Global Scope has failed.    
   |                                                              ^^^^ help: consider using four spaces per tab
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments
   = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default