Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RootSet approach to getRootAt #119

Merged
merged 4 commits into from
Jan 2, 2023
Merged

Conversation

lok52
Copy link
Collaborator

@lok52 lok52 commented Dec 23, 2022

Changes:

  • Remove RootSet storage and use new getRootAt method instead. It calculates Merkle Tree root at any given past index in one bottom-top tree traversal. As tree height is only 48, this should not slow down corresponding validation checks while greatly simplifying current algorithm logic.

Copy link

@k1rill-fedoseev k1rill-fedoseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please fix merge conflict

@akolotov
Copy link

Will be merged as soon as #116 is closed.

@akolotov akolotov merged commit c0befce into devel Jan 2, 2023
@akolotov akolotov deleted the enhancement/root-lookup branch January 2, 2023 08:38
akolotov added a commit that referenced this pull request Jan 16, 2023
This merge contains the following set of changes:
  - Change RootSet approach to getRootAt (#119)
  - Introduction of support id (#121)
  - New endpoint to get the relayer version (#122)
  - Pause workers on insufficient balance error (#123)
  - Add HTTPS URL validation (#124)
  - RPC sync check introduction to switch to fallback RPCs (#128)
  - Fix missing configuration variables (#130)
  - Fix events block range (#134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants