Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bugs #218

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Fix minor bugs #218

merged 5 commits into from
Jun 10, 2024

Conversation

AllFi
Copy link

@AllFi AllFi commented Jun 6, 2024

In this PR, the following changes were made:

  • Fixed a potential issue with gaps in blocks processed by the indexer.
  • Moved INDEXER_BLOCK_CONFIRMATIONS to the configuration file.
  • Ensured that COMMITMENT_WATCHER_FEE is now consistent with the RELAYER_FEE parameter and specified in token decimals.

@AllFi AllFi requested review from EvgenKor, lok52 and r0wdy1 June 6, 2024 12:35
Copy link

@r0wdy1 r0wdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@r0wdy1 r0wdy1 merged commit b83b7e8 into feature/on-confirmed Jun 10, 2024
1 check passed
r0wdy1 added a commit that referenced this pull request Jun 14, 2024
* updates job status on queue inclusion

* Remove additional logic from getTransactionV2

* Added /proverAddress endpoint

* Propagating job validation error

* Job error description

* Trying to restore balance waiting routine

* Optimistic state for sent transactions

* Updating txHash in cached txs, introducing pendingDeltaIndex field in /info endpoint

* Setting reverted state to failed txs

* Clearing pending cache on tx revert

* Fix minor bugs (#218)

* Fix potential indexer gap

* Fix prover fee

* Don't import FeeOptions

* Use applyDenominator

* Move INDEXER_BLOCK_CONFIRMATIONS to config

* Update zp-relayer/workers/sentTxWorker.ts

Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>

* Update zp-relayer/pool/RelayPool.ts

Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>

* Update zp-relayer/pool/BasePool.ts

Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>

* make jobId mandatory for onFailed callback

---------

Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>
Co-authored-by: EvgenKor <evgen2k7@yandex.ru>
r0wdy1 added a commit that referenced this pull request Aug 7, 2024
* Initial TRON support

* Fix error catching

* Support for TRON address type in /limits endpoint

* Minor refactoring

* Remove mock proof

* Make configurable feeLimit

* Add MPC guard service

* MPC relayer

* Fix guard signatures

* Fix guard signature

* Update launch scripts

* Add debug logs

* Handle trongrid error

* Initial

* Update launch script

* Ingore legacy ts errors

* Fix memo offset

* Fix commitment-watcher

* Fix fetching limits from external accounting contract

* Add /fee and /address endpoints for prover

* Fix job state & RelayPool fetcher

* Add /proverFee endpoint

* Fix fee manager init

* Fix RelayPool validation

* Fix commitment processing condition (#215)

* Add indexer service & make relayer stateless

* Fix build

* Add proxy optimistic state

* Fix indexer sync

* Add TxStore

* Fix build

* Fix indexer offset

* Fix prover sync bug (#216)

* Add direct deposits

* Fix watcher init

* updates job status on queue inclusion (#217)

* updates job status on queue inclusion

* Remove additional logic from getTransactionV2

* Added /proverAddress endpoint

* Propagating job validation error

* Job error description

* Trying to restore balance waiting routine

* Optimistic state for sent transactions

* Updating txHash in cached txs, introducing pendingDeltaIndex field in /info endpoint

* Setting reverted state to failed txs

* Clearing pending cache on tx revert

* Fix minor bugs (#218)

* Fix potential indexer gap

* Fix prover fee

* Don't import FeeOptions

* Use applyDenominator

* Move INDEXER_BLOCK_CONFIRMATIONS to config

* Update zp-relayer/workers/sentTxWorker.ts

Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>

* Update zp-relayer/pool/RelayPool.ts

Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>

* Update zp-relayer/pool/BasePool.ts

Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>

* make jobId mandatory for onFailed callback

---------

Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>
Co-authored-by: EvgenKor <evgen2k7@yandex.ru>

* Fix basic dd logic (#219)

* Add COMMITMENT_WATCHER_DIRECT_DEPOSIT_PARAMS_PATH

* Fix dd indexing logic

* Support both formats

* Mark job as failed if the indexer isn't synced yet

* Remove obsolete job

* Fix sync

* Fix sync

* Attempt to fix dd flow

* Remove unnecessary code

* Refactor code

* remove redundant methods

---------

Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>
Co-authored-by: r0wdy1 <103738251+r0wdy1@users.noreply.github.com>
Co-authored-by: EvgenKor <evgen2k7@yandex.ru>
Co-authored-by: vladimir <vladimir@blockscout.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants