Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add merkle root index validation #60

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Add merkle root index validation #60

merged 1 commit into from
Sep 16, 2022

Conversation

lok52
Copy link
Collaborator

@lok52 lok52 commented Sep 15, 2022

Closes #30

@lok52 lok52 requested a review from akolotov September 15, 2022 15:05
akolotov
akolotov reviewed Sep 15, 2022
View reviewed changes
Copy link

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you share more details why checkMerkleRootErrors is needed?

@lok52
Copy link
Collaborator Author

lok52 commented Sep 16, 2022 •
edited
Loading

May you share more details why checkMerkleRootErrors is needed?

@akolotov it prevents relayer from errors mentioned in #30 when user provides incorrect request input. E.g. /merkle/root/asdgasdgasdgasdgasdg

Now, checkMerkleRootErrors validates that index(in /merkle/root/:index) is a number using AjvMerkleRootSchema.

@akolotov akolotov merged commit 8526019 into devel Sep 16, 2022
@akolotov akolotov deleted the fix/index-validation branch September 16, 2022 13:41
@akolotov akolotov mentioned this pull request Oct 29, 2022
Merged
akolotov added a commit that referenced this pull request Nov 1, 2022
@akolotov
Merge the devel branch into the main branch, v2.0.0
c894e4c 
This merge contains the following set of changes:
- Remove /proof_tx endpoint (#59)
- Add merkle root index validation (#60)
- Add endpoints for parameters hash (#65)
- Improvements in user tx validation (#69)
- Update ZkBobPool ABI (#71)
- Configuration ability fo DB files dir (#79)
- Bunch of improvements to robust transaction sending (#78)
- Maintenance of merkle root for more robust transaction verification (#76)
- Add fallback in root lookup method (#86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Error: invalid BigNumber string" on the staging relayer
2 participants
@lok52 @akolotov