forked from zeropoolnetwork/zeropool-relayer
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/updated hash #97
Merged
Merged
Fix/updated hash #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1rill-fedoseev
requested changes
Nov 9, 2022
lok52
force-pushed
the
fix/updated-hash
branch
from
November 9, 2022 14:36
9a4f87a
to
e779efd
Compare
k1rill-fedoseev
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
EvgenKor
reviewed
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. It's need to test it on the staging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
debug
level toinfo
in some placeswaiting
,failed
,sent
,reverted
,completed
. Description:waiting
- job is waiting in queue or being processed bypoolTxWorker
failed
- job failed validation step before it was submitted to contractsent
- job is being processed bysentTxWorker
reverted
- job got a confirmed revertcompleted
- job completed successfullyExpected
/job/:id
response type for each status:waiting
:failed
:sendt
:reverted
:completed
:JobIdsMapping
. It is required to track statuses of re-submitted topoolTxQueue
failed jobs. After job is re-submitted back to the queue, a new record is stored in redis linking original pool job id to the new one.