New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative denominator support #143

Closed

r0wdy1 opened this issue Jul 4, 2023 · 0 comments · Fixed by #147

Assignees

r0wdy1 commented Jul 4, 2023 •

edited

Loading

Add support for multiple denominators in the pool, i.e. add an extra coefficient so that the result would correspond to token denominator taking into account native pool denominator 1e9. Therefore for USDC ( 1e6) all operations values must be multiplied by 1e3. Inverse denominator can be obtained from the contract - https://github.com/zkBob/zkbob-contracts/pull/79/files#diff-e323fb0df158445703db898a290a14791771e48f31c6f10add5bb86df87311f8R152

r0wdy1 assigned EvgenKor

r0wdy1 mentioned this issue

Migrate to USDC zkBob/zkbob-contracts#80

Closed

6 tasks

r0wdy1 linked a pull request

that will close this issue

Negative denominator support #147

Merged

r0wdy1 removed a link to a pull request

Negative denominator support #147

Merged

r0wdy1 linked a pull request

that will close this issue

Negative denominator support #147

Merged

r0wdy1 changed the title ~~add Pool.tokenAddress change history to config~~ Negative denominator support

maikReal closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment