Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative denominator support #147

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Negative denominator support #147

merged 4 commits into from
Jul 10, 2023

Conversation

EvgenKor
Copy link
Collaborator

@EvgenKor EvgenKor commented Jul 6, 2023 •
edited
Loading

To support pool migration (BOB -> USDC) the negative denominators should supported by library. The denominator with 1 in MSB considered to be a negative. And we should multiple native amount to get the pool resolution (instead dividing)

There are any changes in the library interfaces and method signatures

Please use the corresponding console branch to check it zkBob/zkbob-console#88

@EvgenKor EvgenKor mentioned this pull request Jul 6, 2023
Merged
@EvgenKor EvgenKor mentioned this pull request Jul 7, 2023
Merged
@akolotov akolotov merged commit 482a660 into develop Jul 10, 2023
@akolotov akolotov deleted the feature/neg-denominator branch July 10, 2023 19:08
@akolotov akolotov mentioned this pull request Jul 10, 2023
Merged
akolotov added a commit that referenced this pull request Jul 10, 2023
@akolotov
Merging the develop branch into the main branch, v5.1.0
1413224 
This merge contains the following set of changes:
  - Tooling for Direct Deposits (#144)
  - Support of USDC pool migrated from BOB (#147)
  - Added ability to redeem gift-card for exact value (#148)
@r0wdy1 r0wdy1 linked an issue Jul 11, 2023 that may be closed by this pull request
Negative denominator support #143
Closed
@r0wdy1 r0wdy1 removed a link to an issue Jul 11, 2023
Negative denominator support #143
Closed
@r0wdy1 r0wdy1 linked an issue Jul 11, 2023 that may be closed by this pull request
Negative denominator support #143
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1rill-fedoseev k1rill-fedoseev k1rill-fedoseev approved these changes

@AllFi AllFi Awaiting requested review from AllFi

@akolotov akolotov Awaiting requested review from akolotov

@lok52 lok52 Awaiting requested review from lok52

@r0wdy1 r0wdy1 Awaiting requested review from r0wdy1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative denominator support
3 participants
@EvgenKor @k1rill-fedoseev @akolotov