Hotfix for partial tree update #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgenKor
requested review from
AllFi,
akolotov,
lok52,
k1rill-fedoseev and
r0wdy1
lok52
approved these changes
Dec 25, 2022
k1rill-fedoseev
approved these changes
Dec 26, 2022
akolotov
reviewed
Dec 26, 2022
src/client.ts
Outdated
| // fetch current birthindex right away | ||
| try { | ||
| let curIndex = Number((await client.info(token.relayerUrl)).deltaIndex); | ||
| const OUTPLUSONE = CONSTANTS.OUT + 1; |
There was a problem hiding this comment.
you define OUTPLUSONE twice here and at the line 1387. Should we move its definition to the section (lines 27-38) where all constant are defined?
There was a problem hiding this comment.
Yes, make sense. Moved in 46fc276
AllFi
approved these changes
Dec 26, 2022
src/client.ts
Outdated
| // set -1 to use the latest index (create _NEW_ account) | ||
| birthindex: number | undefined; | ||
| // Account birthday [moved to Token object] | ||
| //birthindex: number | undefined; |
There was a problem hiding this comment.
I think there is no need to leave it in the code. Git remembers everything :)
akolotov
approved these changes
Dec 26, 2022
akolotov
added a commit
that referenced
this pull request
Dec 26, 2022
This merge contains the following set of changes: - Hotfix for getting partial tree (#73)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is hotfixes for the client library for errors discovered during latest testing