Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix deploy target for prod #24

Merged
merged 1 commit into from
Jun 5, 2024
Merged

chore: fix deploy target for prod #24

merged 1 commit into from
Jun 5, 2024

Conversation

itsacoyote
Copy link
Contributor

Description

Remove target for prod deploy workflow. This tries to search for a target defined in firebase.json. We don't have any targets defined since our configuration shouldn't be any different for staging and prod deploys.

@itsacoyote itsacoyote requested a review from a team as a code owner June 5, 2024 15:42
Copy link

github-actions bot commented Jun 5, 2024

Visit the preview URL for this PR (updated for commit 70787e3):

https://community-cookbook-staging--pr24-fix-prod-deploy-xea760zw.web.app

(expires Wed, 12 Jun 2024 15:44:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1b876338aafcf55b4a02f1877984e116731756b1

Copy link
Contributor

@AlbionaHoti AlbionaHoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@itsacoyote itsacoyote merged commit 0152656 into main Jun 5, 2024
7 checks passed
@itsacoyote itsacoyote deleted the fix-prod-deploy branch June 5, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants