Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tutorial for Permissionless Multisigner paymaster #37

Closed
wants to merge 21 commits into from

Conversation

hoshiyari420
Copy link
Contributor

Description

This pull request introduces the following changes:

  1. Adds a new tutorial on integrating a permissionless multi-signer paymaster in the tutorials folder.
  2. Includes supporting images for the tutorial in the public/images folder.

Overview

The tutorial provides technical guidance on integrating Zyfi's new permissionless, signature-based paymaster into any Dapp. This paymaster offers Dapps greater flexibility by allowing the use of paymaster functionality without relying on third-party services. Additionally, it helps save Dapps' resources by eliminating the need to develop or deploy a custom paymaster.

@hoshiyari420 hoshiyari420 requested a review from a team as a code owner August 6, 2024 14:31
Copy link
Contributor

@sarahschwartz sarahschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I have some grammar nits:

content/tutorials/permissionless-paymaster/10.index.md Outdated Show resolved Hide resolved
content/tutorials/permissionless-paymaster/10.index.md Outdated Show resolved Hide resolved
content/tutorials/permissionless-paymaster/10.index.md Outdated Show resolved Hide resolved
content/tutorials/permissionless-paymaster/10.index.md Outdated Show resolved Hide resolved
content/tutorials/permissionless-paymaster/10.index.md Outdated Show resolved Hide resolved
content/tutorials/permissionless-paymaster/10.index.md Outdated Show resolved Hide resolved
content/tutorials/permissionless-paymaster/10.index.md Outdated Show resolved Hide resolved
content/tutorials/permissionless-paymaster/10.index.md Outdated Show resolved Hide resolved
content/tutorials/permissionless-paymaster/10.index.md Outdated Show resolved Hide resolved
content/tutorials/permissionless-paymaster/10.index.md Outdated Show resolved Hide resolved
hoshiyari420 and others added 3 commits August 7, 2024 21:53
Co-authored-by: Antonio <tonioufa@gmail.com>
fix: suggested grammar nits

Co-authored-by: Sarah Schwartz <58856580+sarahschwartz@users.noreply.github.com>
sarahschwartz
sarahschwartz previously approved these changes Aug 14, 2024
@hoshiyari420
Copy link
Contributor Author

hoshiyari420 commented Aug 15, 2024

Hi team @uF4No @JackHamer09 @sarahschwartz ,
Thanks to @sarahschwartz feedback, have upgraded the tutorial showcasing full integration guide.
Please do review it.
edit: please suggest a change to remove the bun.lockb update. I tried to resolve it but it still shows merge conflict error.

Copy link
Contributor

@sarahschwartz sarahschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking a lot better, great job! I just have a few notes:

Also for the bun.lockb file, you should just be able to run bun install to resolve the diff. If that doesn't work, try deleting the file and then installing again.

@sarahschwartz
Copy link
Contributor

@hoshiyari420 I just approved but I apologize I didn't realize there is one more issue here: our repo requires all commits to be signed: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

hoshiyari420 and others added 2 commits August 23, 2024 00:40
Signed-off-by: hoshiyari <hoshiyari420@gmail.com>
* feat: l1-l2 how to guide

* fix: broken link

* fix: linting

* fix: rename title

* fix: format steps

* fix: pk notes

* Apply suggestions from code review

Co-authored-by: Sabrina <sf@matterlabs.dev>

* fix: pr review comments

* Update content/tutorials/how-to-send-l1-l2-transaction/10.index.md

Co-authored-by: Sabrina <sf@matterlabs.dev>

---------

Co-authored-by: Sabrina <sf@matterlabs.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants