Skip to content
This repository has been archived by the owner on Jul 6, 2019. It is now read-only.

Add German translations #79

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Add German translations #79

merged 1 commit into from
Jul 12, 2017

Conversation

simonua
Copy link
Contributor

@simonua simonua commented Jul 12, 2017

Addresses #39 for German (de).

@zkat, Would be good for another native speaker to review, but I think it's probably ~90% accurate ("deutsche Sprache, schwere Sprache") - definitely enough to inform what's meant and what's going on.

What do you set in an environment to use a locale other than the default?

@zkat
Copy link
Owner

zkat commented Jul 12, 2017

@simonua LC_ALL=de npx ...

@simonua
Copy link
Contributor Author

simonua commented Jul 12, 2017

@zkat, ah, the Unix way. That won't work quite like that on Windows. Will have to check there. Maybe just change the language in the System to see whether/how it affects npx.

@katemihalikova
Copy link
Collaborator

katemihalikova commented Jul 12, 2017

@simonua It uses os-locale under the hood which tries to read env vars before falling back to reading OS config. You can run set LC_ALL=de to set/change the env var (for current cmd.exe window only). npx will then pick de locale up, but OS won't be otherwise affected because it's not a system env var.

@simonua
Copy link
Contributor Author

simonua commented Jul 12, 2017

@katemihalikova @zkat, the things I learn from you. =)

Thank you!

image

@zkat zkat added the i18n label Jul 12, 2017
@zkat
Copy link
Owner

zkat commented Jul 12, 2017

@simonua unless something strikes me as particularly obvious, I tend to just merge any ok-ish-looking PRs from people who I'm reasonably certain are native speakers. If there's a mistake, I'd rather take what's there and have a different native speaker roll in and fix it later. 👍

@zkat zkat merged commit c81e26d into zkat:latest Jul 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants