improve check for truecolor #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support COLORTERM=24bit. * As documented at https://github.com/termstandard/colors#checking-for-colorterm, COLORTERM is not sent over the wire with ssh by default. This means that programs that use supports-color don't get truecolor over ssh. To address that, check that TERM ends with either "direct" or "truecolor". I think the latter check should be "-direct" or "-truecolor", but `check_256_color` below doesn't check for a hyphen either. Should that be addressed as well?
|
I think this is fine tbh. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the latter check should be "-direct" or "-truecolor", but
check_256_colorbelow doesn't check for a hyphen either. Should that be addressed as well?