RELIC interop #57
Merged
RELIC interop #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmerge try |
bmerge
added a commit
that referenced
this pull request
Oct 3, 2017
RELIC interop Closes #2 RELIC has changed the G2 generator to match ours: relic-toolkit/relic@25aafec RELIC will not have the same serialization as us. One last difference is that RELIC conjugates the pairing result to account for the negative curve parameter. It doesn't matter for BLS curves but it's strictly more correct.
|
☀️ Test successful - pairing-linux32-try, pairing-linux64-try, pairing-windows32msvc-try, pairing-windows64msvc-try |
daira
approved these changes
Oct 4, 2017
| assert_eq!(Bls12::pairing(G1::one(), G2::one()), Fq12 { | ||
| c0: Fq6 { | ||
| c0: Fq2 { | ||
| c0: Fq::from_str("2819105605953691245277803056322684086884703000473961065716485506033588504203831029066448642358042597501014294104502").unwrap(), |
There was a problem hiding this comment.
It might be better to do the conversion from hex in code so that it's more easily visible how this relates to the test vector above.
There was a problem hiding this comment.
Opened #59 because I agree.
|
@bmerge r+ |
|
📌 Commit 18c75f1 has been approved by |
bmerge
added a commit
that referenced
this pull request
Oct 4, 2017
RELIC interop Closes #2 RELIC has changed the G2 generator to match ours: relic-toolkit/relic@25aafec RELIC will not have the same serialization as us. One last difference is that RELIC conjugates the pairing result to account for the negative curve parameter. It doesn't matter for BLS curves but it's strictly more correct.
|
☀️ Test successful - pairing-linux32-auto, pairing-linux64-auto, pairing-windows32msvc-auto, pairing-windows64msvc-auto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
RELIC has changed the G2 generator to match ours: relic-toolkit/relic@25aafec
RELIC will not have the same serialization as us.
One last difference is that RELIC conjugates the pairing result to account for the negative curve parameter. It doesn't matter for BLS curves but it's strictly more correct.