Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace circom and halo2 seperately #180

Closed
chancehudson opened this issue Jun 22, 2024 · 1 comment · Fixed by #190
Closed

Namespace circom and halo2 seperately #180

chancehudson opened this issue Jun 22, 2024 · 1 comment · Fixed by #190

Comments

@chancehudson
Copy link
Collaborator

We have a bunch of functions for generating proofs, serializing, etc. These functions are exposed in a global way to the mobile side and we're using compiler flags to swap which function is enabled. This is a bit of a mess when trying to parse the logic. It also prevents compiling with support for both circom and halo2 at the same time.

Instead we should namespace the halo2 and circom logic separately and use a single compiler flag to enable or disable the modules. Better yet, we could always compile support for both modules and avoid conditional compile logic altogether.

@chancehudson chancehudson mentioned this issue Jun 25, 2024
22 tasks
@oskarth
Copy link
Collaborator

oskarth commented Jun 25, 2024

Instead we should namespace the halo2 and circom logic separately and use a single compiler flag to enable or disable the modules.

Agree with this.

Better yet, we could always compile support for both modules and avoid conditional compile logic altogether.

This leads to library bloat which is a problem in resource restricted environments. We don't want this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants