tracking #182 (bob de boumaa rework) #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: rename rsa circuit from main to main_rsa remove wasmer dep remove static proof generation logic, in memory zkey, etc add rust_witness chore: switch to git copy of rust-witness fix: rsa circuit path fix: mutability fix: re-enable example fix: move witness fn into scope refactor: register list of proofs fix: build anonaadhaar wasm to fix ci refactor: remove wasm path fix: zkey pathing chore: remove wasmer ref chore: switch to wasm delete copy of circom-compat * chore: remove mutability and ignore * chore: comment anonaadhaar build chore: switch to zkmopro circom-compat fork chore: update cargo lock * fix: compile error in build script * fix: put anonaadhaar tests behind feature flag * chore: remove wasmer deps * refactor: pass zkey path through ffi bridge * chore: rebase, revert name changes * chore: comments * chore: fix halo2 build * chore: conditionals...............
refactor: separate circom/halo2 functions in udl
chore(ci): split circom and halo2 tests
chancehudson
changed the title
chancehudson
force-pushed
the
core-delete-2
branch
from
78824a0 to
7a6a7d7
Compare
chancehudson
force-pushed
the
core-delete-2
branch
from
3948e34 to
573a9c4
Compare
fix: don't export circom and halo2 modules
oskarth
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Thanks for spike to integrate rust-witness.
However, this PR is too big with a massive surface area, impossible to review. It is also not actually targeting any specific identified issue, and probably contains 5-10 different issues, that may or may not be a problem.
See message in group chat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.rsthat calls the above rust implementations (build_ios, build_android, etc)cargo buildinstead ofmopro buildThis PR transfers the proving logic from mopro-core to mopro-ffi. The
examplesdirectory is removed and the artifacts are committed directly intomopro-ffi/test-vectors. All the circuits except formultiplier2andkeccak256have been removed.Proving functions are now:
generate_circom_proofverify_circom_proofgenerate_halo2_proofverify_halo2_proofThe halo2/circom logic is also separated so they can be enabled at the same time.
Related #182
Closes #180