Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halo2 circuit in mopro (redesigned) #214

Merged
merged 44 commits into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
f5ececa
(feat: halo2) first draft of halo2 circuit in mopro
ElusAegis Jul 10, 2024
a39c068
(feat: circom) changed circom to be friendly for non-declaration case…
ElusAegis Jul 11, 2024
3db5c11
(feat: circom) changed structure to make circom included in compile time
ElusAegis Jul 11, 2024
b968272
(feat: halo2) changed structure to make halo2 included in compile tim…
ElusAegis Jul 11, 2024
c56ddcb
(feat: circom) improved internal layout for circom
ElusAegis Jul 11, 2024
843b88f
(fix: macro) fixed test issue with path of the files used instead of …
ElusAegis Jul 11, 2024
4aa1d28
(fix: test) fixed a test to run correctly
ElusAegis Jul 11, 2024
60a3d41
(chore: dep) Improved how dependencies are specified, making `big-num…
ElusAegis Jul 11, 2024
710d386
(chore: imports) Made the `one-cell` inport unnessessary in `test-e2e…
ElusAegis Jul 11, 2024
287ab5e
(chore: docs) Added docs on the macros
ElusAegis Jul 11, 2024
959c565
(chore: test-e2e) Clean up example
ElusAegis Jul 11, 2024
c5992c8
(fix: halo2) Fixed a bug in how halo2 error on unknown circuit is pri…
ElusAegis Jul 11, 2024
71725c2
(chore: halo2) Cleaned up the `test-e2e/lib.rs` halo2 example
ElusAegis Jul 11, 2024
4b2fede
(feat: halo2) added a test case for Halo2
ElusAegis Jul 11, 2024
7cb53e1
(chore: sample) A cleaner sample with a features set to work with dif…
ElusAegis Jul 11, 2024
1dee772
(chore: sample) A cleaner sample with a features set to work with dif…
ElusAegis Jul 11, 2024
a0a186f
(feat: halo2) Added FFI tests to test macros
ElusAegis Jul 11, 2024
ff86a78
(feat: circom) Added Circom tests of macros
ElusAegis Jul 11, 2024
192a9ab
(chore: circom) Cleanup of tests as well as imports
ElusAegis Jul 10, 2024
075da59
(feat: halo2) Updated bindings with new halo2 types
ElusAegis Jul 11, 2024
a9beaa4
(feat: halo2) Updated ios project to show how to work with Halo2
ElusAegis Jul 11, 2024
df0b8cd
(feat: halo2) Updated android bindings
ElusAegis Jul 11, 2024
7a1bc98
(fix: circom) Fix an issue of compilation with only circom flag
ElusAegis Jul 11, 2024
0980593
(fix: halo2) Updated dependencies to resolve android compilation issue
ElusAegis Jul 11, 2024
8b14584
(fix: ios) Fixed test in IOS to match changed IOS App
ElusAegis Jul 11, 2024
fbc55ac
(fix: dep) Removed unused dependencies
ElusAegis Jul 11, 2024
06d1e16
(feat: test-e2e) Removed feature conditional compilation from the `te…
ElusAegis Jul 12, 2024
8eea240
(feat: ci) Updated CI to run Halo2 tests
ElusAegis Jul 12, 2024
c9551fb
(feat: circom) Proposed a redesigned way to set circom circuits, avoi…
ElusAegis Jul 12, 2024
acc9dcb
(chore: circom) Added more docs to the circom `set_circom_circuits` m…
ElusAegis Jul 12, 2024
4656aae
(feat: circom) Redesigned circom `set_circom_circuits` macro to pass …
ElusAegis Jul 12, 2024
4e78501
(feat: halo2) Redesigned halo2 `set_halo2_circuits` macro to pass inp…
ElusAegis Jul 12, 2024
043136b
(feat: halo2) Added universal error handling and moved logic for fibo…
ElusAegis Jul 12, 2024
fbc7adf
(feat: halo2) Updated Halo2 `mopro-ffi` tests to use `halo2-fibonacci…
ElusAegis Jul 12, 2024
21a800b
(feat: halo2) Added Keccak Circuit implementation as a halo2 example
ElusAegis Jul 12, 2024
6424364
(chore: refactor) Removed unused onecell import
ElusAegis Jul 12, 2024
7c2850b
(chore: refactor) Removed unused dependencies
ElusAegis Jul 12, 2024
3917ae3
(chore: refactor) Added `.bin` extension to halo2 keys
ElusAegis Jul 12, 2024
8f4f5dd
(fix: refactor) Removed some changes that were accidentally inclded
ElusAegis Jul 12, 2024
a6cdc6d
(chore: refactor) Simplified the CI by merging `test-e2e` test tasks …
ElusAegis Jul 15, 2024
2e6c5f0
(chore: refactor) Merged the tests `proof` and `verify` into a single…
ElusAegis Jul 15, 2024
db43d58
Merge branch 'refs/heads/main' into feat/halo2-redesign
ElusAegis Jul 15, 2024
92008de
(chore: cargo.lock) Update cargo lock to merge changes from Main
ElusAegis Jul 15, 2024
d767cb8
(chore: text) Improved the text panic message
ElusAegis Jul 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,8 @@ jobs:
with:
toolchain: stable
override: true
- name: Build package with halo2 config
run: cd mopro-ffi && cargo build --features halo2 --no-default-features
### Halo2 tests will fail until we replace the stub implementation
### just build to make sure the flags don't cause errors
# - name: Run halo2 tests
# # TODO: Fix this custom jar thing
# run: |
# cd mopro-ffi/
# curl -L https://repo1.maven.org/maven2/net/java/dev/jna/jna/5.13.0/jna-5.13.0.jar -o jna-5.13.0.jar
# CLASSPATH=jna-5.13.0.jar cargo test -- --nocapture
# cargo test --features halo2 --no-default-features

- name: Run ffi halo2 tests
run: cd mopro-ffi && cargo test --features halo2 --no-default-features
test-ffi-circom:
runs-on: ubuntu-latest
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
Expand Down Expand Up @@ -71,7 +61,23 @@ jobs:
run: |
cd test-e2e
curl -L https://repo1.maven.org/maven2/net/java/dev/jna/jna/5.13.0/jna-5.13.0.jar -o jna-5.13.0.jar
CLASSPATH=jna-5.13.0.jar cargo test -- --nocapture
CLASSPATH=jna-5.13.0.jar cargo test --test circom -- --nocapture
test-e2e-halo2:
runs-on: ubuntu-latest
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
steps:
- uses: actions/checkout@v4
- name: Install Rust toolchain
uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
- name: Run e2e halo2 tests
# TODO: Fix this custom jar thing
run: |
cd test-e2e
curl -L https://repo1.maven.org/maven2/net/java/dev/jna/jna/5.13.0/jna-5.13.0.jar -o jna-5.13.0.jar
CLASSPATH=jna-5.13.0.jar cargo test --test halo2 -- --nocapture
ElusAegis marked this conversation as resolved.
Show resolved Hide resolved
build-xcframework:
runs-on: macos-latest
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
Expand Down
Loading
Loading