Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5: Range Checks #7

Closed
georgwiese opened this issue May 5, 2023 · 1 comment · Fixed by #15
Closed

5: Range Checks #7

georgwiese opened this issue May 5, 2023 · 1 comment · Fixed by #15
Assignees
@georgwiese

Comments

@georgwiese
Copy link
Member

georgwiese commented May 5, 2023 •
edited
Loading

We're currently not performing any range checks. I started implementing them on the halo2gadgets branch (using, you guessed it, halo2_gadgets), but it's blocked by privacy-scaling-explorations/halo2curves#37.
@georgwiese georgwiese converted this from a draft issue May 5, 2023
@georgwiese georgwiese changed the title Range Checks 5: Range Checks May 5, 2023
@georgwiese
Copy link
Member Author

Luckily, the mentioned issue is being addressed by privacy-scaling-explorations/halo2curves#40. I validated that it indeed fixes the problem by switching back to the BN256 curve on the halo2_gadgets branch.

Once this PR is merged, I consider this issue unblocked. We can fork halo2 until they update to the latest halo2curves.

@georgwiese georgwiese mentioned this issue May 17, 2023
Merged
@georgwiese georgwiese self-assigned this May 17, 2023
@georgwiese georgwiese moved this from Blocked to Todo in Zero Gravity May 17, 2023
@georgwiese georgwiese moved this from Todo to In Progress in Zero Gravity May 17, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Zero Gravity May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgwiese georgwiese

Labels
None yet
Projects
Zero Gravity
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add range checks via halo2_gadgets zkp-gravity/0g-halo2
1 participant
@georgwiese