Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PrimeFieldBits for base and scalar field of BN and Secp #40

Merged
merged 5 commits into from
May 17, 2023
Merged

Implement PrimeFieldBits for base and scalar field of BN and Secp #40

merged 5 commits into from
May 17, 2023

Conversation

han0110
Copy link
Contributor

@han0110 han0110 commented May 10, 2023 •
edited
Loading

Also

  • Restrict Engine::Scalar to PrimeField since other associated types are already PrimeCurve, this can help us to remove the need to specify E::Scalar: PrimeField when using Engine trait.
  • Update rust-toolchain to use stable channel by default

Resolves #37

@han0110 han0110 mentioned this pull request May 10, 2023
Merged
@georgwiese georgwiese mentioned this pull request May 11, 2023
Closed
@han0110 han0110 requested a review from kilic May 15, 2023 04:51
davidnevadoc
davidnevadoc approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
We could extend the tests to cover these new functions, but I don't think it is a must.

@han0110
Copy link
Contributor Author

han0110 commented May 16, 2023 •
edited
Loading

Totally forget about the test, just added it in c96a504, thanks for reminding!

@han0110 han0110 merged commit a92a130 into privacy-scaling-explorations:main May 17, 2023
@han0110 han0110 deleted the feature/ff-bits branch May 17, 2023 03:48
@kilic kilic mentioned this pull request Oct 25, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidnevadoc davidnevadoc davidnevadoc approved these changes

@kilic kilic Awaiting requested review from kilic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PrimeFieldBits
2 participants
@han0110 @davidnevadoc