Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeakMap.prototype.get/has/delete may throw in old Chrome #124

Closed
loganfsmyth opened this issue Oct 26, 2015 · 0 comments
Closed

WeakMap.prototype.get/has/delete may throw in old Chrome #124

loganfsmyth opened this issue Oct 26, 2015 · 0 comments
Labels

Comments

@loganfsmyth
Copy link
Contributor

Just encountered on a user's machine, so I didn't get to play around with it much, but they were getting TypeError: Invalid value used as weak map key which lead me to https://code.google.com/p/chromium/issues/detail?id=460083.

The user was still on Chrome 40, and our code was basically doing .get(null) and expecting a falsy value, which the spec defines as undefined 23.3.3.3 step #5. Instead, Chrome 40 was throwing an exception.

@zloirock zloirock added the v8 label Oct 26, 2015
zloirock added a commit that referenced this issue Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants