-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in node 0.10, Map.prototype.forEach.call({}, function () {})
does not throw
#144
Comments
I saw this issue. I don't think it is a principal behavior for polyfill, but ok, I will add it. |
It's the only reliable way to determine if something is a Map or Set, cross-realm (ie, not relying on |
👍 Thanks, @zloirock! This is important for feature detection. |
Also add `npm run test:corejs`. Relates to #4.
Thanks! Please let me know when you release a v2.0.0 |
Any update? I'd love to verify that |
Available |
Great, thanks! |
Available in 2.0. |
Map#forEach
andSet#forEach
are supposed to throw aTypeError
if their receiver/"this" value is not an actual Map or Set. In node 0.12 and later, withcore-js
required, it throws as expected, but in node 0.10 and earlier, it does not.This is preventing
is-equal
andexpect
from working withcore-js
in an environment without nativeMap
andSet
, since it gives false positives for object values.The text was updated successfully, but these errors were encountered: