Always perform e_cert_unique_identifier_version_not_2_or_3 #711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint e_cert_unique_identifier_version_not_2_or_3 checks whether the unique identifier(s) is present and then checks that the version is correct. Lint lint_cert_extensions_version_not_3.go takes another approach. It always performs the linting and the check is done during execution as one step. Both are very similar cases and the implementation could be aligned. Proposal: always perform e_cert_unique_identifier_version_not_2_or_3 and check inside the execution the presence and correct values. (Alternatively align lint_cert_extensions_version_not_3 to the approach of e_cert_unique_identifier_version_not_2_or_3.)