Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always perform e_cert_unique_identifier_version_not_2_or_3 #711

Merged
merged 10 commits into from
May 14, 2023

Conversation

mtgag
Copy link
Contributor

@mtgag mtgag commented Apr 27, 2023

Lint e_cert_unique_identifier_version_not_2_or_3 checks whether the unique identifier(s) is present and then checks that the version is correct. Lint lint_cert_extensions_version_not_3.go takes another approach. It always performs the linting and the check is done during execution as one step. Both are very similar cases and the implementation could be aligned. Proposal: always perform e_cert_unique_identifier_version_not_2_or_3 and check inside the execution the presence and correct values. (Alternatively align lint_cert_extensions_version_not_3 to the approach of e_cert_unique_identifier_version_not_2_or_3.)

Copy link
Member

@christopher-henderson christopher-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this makes sense since it technically applies to all certificates.

@christopher-henderson christopher-henderson merged commit 2438596 into zmap:master May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants