Add lint for S/MIME subject directory attributes extension (7.1.2.3j) #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-henderson
approved these changes
Feb 19, 2024
| InputFilename: "smime/mailboxValidatedStrictWithCommonName.pem", | ||
| ExpectedResult: lint.Pass, | ||
| }, | ||
| // A negative test case is hard to construct because neither the x509 package |
There was a problem hiding this comment.
This does indeed happen and there a handful of such cases throughout this code base where producing a negative example is (thankfully?) quite difficult without facing the daunting task of constructing these certificates nearly by hand.
Fortunately, the test corpus helps save us from ourselves by grapping hundreds-of-thousands of certificates from the wild to see if there are any examples that we could not catch ourselves.
None of the test corpus failed, which there are nearly 200k SMIME certs. So I guess it suppose the generating libraries just generally do a good job on this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried but failed to create a negative test case for this. The
x509.Certificatetype does not have subject directory attributes, and as far as I can tell, OpenSSL does not support writing them from the command line.