Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/test checkbox #875

Closed
wants to merge 50 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
ab3db29
util: gtld_map autopull updates for 2021-09-28T01:28:51 UTC
web-flow Sep 28, 2021
ab501e3
Merge pull request #1 from magic679/zlint-gtld-update
stefanochang Sep 28, 2021
b4482ed
feat: test push
stefanochang May 12, 2024
448474a
Merge pull request #3 from stefanochang/f/test
stefanochang May 12, 2024
60c5038
feat: changing stuff
stefanochang May 12, 2024
d96721e
feat: refactor pull request template location
stefanochang May 12, 2024
df49c45
Merge pull request #4 from stefanochang/f/second
stefanochang May 12, 2024
17d24fa
feat: made a change
stefanochang May 12, 2024
41ae471
fix: ci script to watch master branch
stefanochang May 13, 2024
aa7ee41
Merge pull request #5 from stefanochang/f/third
stefanochang May 13, 2024
7749ab9
feat: demo pr
stefanochang May 13, 2024
6d986fc
feat: add label to checkboxes
stefanochang May 13, 2024
0de0a10
Merge pull request #6 from stefanochang/f/demo-pr
stefanochang May 13, 2024
a43ce57
feat: demo pr
stefanochang May 13, 2024
5747fc9
feat: add label to checkboxes
stefanochang May 13, 2024
ed1d92c
feat: add more demo checkboxes
stefanochang May 13, 2024
be1ad2b
Merge branch 'master' into f/demo-pr
stefanochang May 13, 2024
e8ab66b
Merge pull request #7 from stefanochang/f/demo-pr
stefanochang May 13, 2024
35b1006
feat: demo pr
stefanochang May 13, 2024
ae57a8e
feat: add sql files
stefanochang May 13, 2024
bd66da3
Merge pull request #8 from stefanochang/f/demo-pr
stefanochang May 13, 2024
ce65e5c
feat: demo pr
stefanochang May 13, 2024
51e3800
feat: merge
stefanochang May 13, 2024
c7d5272
Merge pull request #9 from stefanochang/f/demo-pr
stefanochang May 13, 2024
2a1a62f
feat: demo pr
stefanochang May 13, 2024
3705cb6
feat: merge
stefanochang May 13, 2024
17d826d
feat: dmeo pr
stefanochang May 13, 2024
93bcccc
feat: demo sql changes
stefanochang May 13, 2024
53cfea7
feat: add edit comment tigger
stefanochang May 13, 2024
13d208a
Merge pull request #11 from stefanochang/f/demo-pr
stefanochang May 13, 2024
7787c10
feat: changing stuff
stefanochang May 12, 2024
b5c927d
feat: refactor pull request template location
stefanochang May 12, 2024
0c7e935
feat: made a change
stefanochang May 12, 2024
6c4bc8f
fix: ci script to watch master branch
stefanochang May 13, 2024
68d0448
feat: demo pr
stefanochang May 13, 2024
d87bdc3
feat: add label to checkboxes
stefanochang May 13, 2024
ecb1ab5
feat: add more demo checkboxes
stefanochang May 13, 2024
e37fbba
feat: demo pr
stefanochang May 13, 2024
7ff289f
feat: demo pr
stefanochang May 13, 2024
1cd3633
feat: add sql files
stefanochang May 13, 2024
a1a6cbf
feat: demo pr
stefanochang May 13, 2024
d1771de
feat: merge
stefanochang May 13, 2024
ed95a39
feat: dmeo pr
stefanochang May 13, 2024
86ffaeb
feat: demo sql changes
stefanochang May 13, 2024
5d69aee
feat: add edit comment tigger
stefanochang May 13, 2024
f036f01
feat: demo pr
stefanochang May 13, 2024
2c92476
Merge branch 'master' into f/demo-ch
stefanochang May 13, 2024
666eb44
Merge pull request #13 from stefanochang/f/demo-ch
stefanochang May 13, 2024
ea5e820
feat: add checkbox wf
stefanochang Aug 16, 2024
7cb29d1
feat: add doc to test checkbox
stefanochang Aug 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Description
Update maxmind api key.

Fixes [DUNLOP-1234](google.com)

# Changes
* Update maxmind api key

# How Has This Been Tested?
* Dunlop compiles and starts up

# Checklist:
Please complete the following qualitative checks and tick the checklists when complete.

Standard qualitative check list
<!--Checkmate-->
- [ ] I have performed a self-review of my code
- [ ] I have tested my changes work locally
- [ ] I have made appropriate documentation changes
- [ ] I have a plan to monitor after merging


Sandboxes (select 1)
<!-- Checkmate select=1 -->
- [ ] The changes do not affect sandboxes
- [ ] I have tested my changes work as expected in a sandbox
26 changes: 26 additions & 0 deletions .github/workflows/ci-checklist.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
on:
pull_request:
types: [edited, opened, reopened, synchronize]
issue_comment:

# cancel old edit events being processed
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

name: Checkmate
jobs:
validate-checklists:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Validate Checklists
uses: roryq/checkmate@master
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
paths: |
docs/*.md:
- <!--Checkmate select=2-->
- Strong Consistency
- Availability
- Partition Tolerance
35 changes: 35 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: checkbox-test
on:
pull_request:
types: [edited, opened, reopened, synchronize]
branches: [master]
issue_comment:
types:
- edited

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
validate:
name: checkbox validation
runs-on: ubuntu-latest
steps:
- name: Get PR branch
uses: xt0rted/pull-request-comment-branch@v2
id: comment-branch
- uses: actions/checkout@v3
with:
ref: ${{ steps.comment-branch.outputs.head_ref }}
token: ${{ secrets.GITHUB_TOKEN }}
- name: Validate Checklists
uses: roryq/checkmate@master
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
paths: |
v3/sql/*.sql:
- I have benchmarked the SQL changes
# - <!--Checkmate select=2-->
# - Partition Tolerance

2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints,
over a single large PR. This allows for better code review, faster turnaround
times on comments and merging, as well as for contributors to learn from any
requested changes in the initial round of review. We are happy to wait to cut
new a version of ZLint until a set of PRs have been approved and merged.
new a version of ZLint until a set of PRs have been approved and merged. to merge.

Adding New Lints
----------------
Expand Down
1 change: 1 addition & 0 deletions docs/test.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
first test file
1 change: 1 addition & 0 deletions v3/sql/test.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
select * from driver;
2 changes: 1 addition & 1 deletion v3/util/gtld_map.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading