Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with using revoke_tokens_on_logout = true #253

Closed
arcivanov opened this issue Mar 17, 2019 · 0 comments · Fixed by #254
Closed

Bug with using revoke_tokens_on_logout = true #253

arcivanov opened this issue Mar 17, 2019 · 0 comments · Fixed by #254

Comments

@arcivanov
Copy link
Contributor

Turning on revoke_tokens_on_logout produces the following warning in the logs.

_G write guard:12: __newindex(): writing a global lua variable ('err') which may lead to race conditions between concurrent requests, so prefer the use of 'local' variables
stack traceback:
	/usr/local/share/lua/5.1/resty/openidc.lua:1171: in function 'openidc_revoke_token'
	/usr/local/share/lua/5.1/resty/openidc.lua:1213: in function 'openidc_logout'
	/usr/local/share/lua/5.1/resty/openidc.lua:1381: in function 'authenticate'

PR to follow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant